Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(preprocessor): obey Pattern.isBinary when set #3422

Merged
merged 1 commit into from
Feb 20, 2020
Merged

feat(preprocessor): obey Pattern.isBinary when set #3422

merged 1 commit into from
Feb 20, 2020

Conversation

johnjbarton
Copy link
Contributor

Add support for isBinary. If set, use it and don't probe file to detect binary status.
Fixes #3405

@karmarunnerbot
Copy link
Member

✅ Build karma 82 completed (commit 497b1c454c by @johnjbarton)

@karmarunnerbot
Copy link
Member

✅ Build karma 81 completed (commit 497b1c454c by @johnjbarton)

@AppVeyorBot
Copy link

✅ Build karma 2480 completed (commit 497b1c454c by @johnjbarton)

@johnjbarton johnjbarton requested a review from kyliau February 12, 2020 00:39
@AppVeyorBot
Copy link

✅ Build karma 2484 completed (commit 292fea95e3 by @johnjbarton)

@karmarunnerbot
Copy link
Member

✅ Build karma 86 completed (commit 292fea95e3 by @johnjbarton)

@karmarunnerbot
Copy link
Member

✅ Build karma 85 completed (commit 292fea95e3 by @johnjbarton)

@AppVeyorBot
Copy link

✅ Build karma 2485 completed (commit c71e8b6e55 by @johnjbarton)

@karmarunnerbot
Copy link
Member

✅ Build karma 87 completed (commit c71e8b6e55 by @johnjbarton)

@karmarunnerbot
Copy link
Member

✅ Build karma 86 completed (commit c71e8b6e55 by @johnjbarton)

@karmarunnerbot
Copy link
Member

✅ Build karma 88 completed (commit 4c87324ef4 by @johnjbarton)

@karmarunnerbot
Copy link
Member

✅ Build karma 87 completed (commit 4c87324ef4 by @johnjbarton)

@AppVeyorBot
Copy link

✅ Build karma 2486 completed (commit 4c87324ef4 by @johnjbarton)

@johnjbarton
feat(preprocessor): obey Pattern.isBinary when set
7ebf78b 
Add support for isBinary.
If set, use it and don't probe file to detect binary status.

Fixes karma-runner#3405
@AppVeyorBot
Copy link

✅ Build karma 2494 completed (commit ef989f79b1 by @johnjbarton)

@karmarunnerbot
Copy link
Member

✅ Build karma 96 completed (commit ef989f79b1 by @johnjbarton)

@karmarunnerbot
Copy link
Member

✅ Build karma 95 completed (commit ef989f79b1 by @johnjbarton)

@johnjbarton johnjbarton merged commit 708ae13 into karma-runner:master Feb 20, 2020
karmarunnerbot pushed a commit that referenced this pull request Apr 9, 2020
@semantic-release-bot
chore(release): 5.0.0 [skip ci]
1b48637 
# [5.0.0](v4.4.1...v5.0.0) (2020-04-09)

### Bug Fixes

* install semantic-release as a regular dev dependency ([#3455](#3455)) ([1eaf35e](1eaf35e))
* **ci:** echo travis env that gates release after_success ([#3446](#3446)) ([b8b2ed8](b8b2ed8))
* **ci:** poll every 10s to avoid rate limit. ([#3388](#3388)) ([91e7e00](91e7e00))
* **middleware/runner:** handle file list rejections ([#3400](#3400)) ([80febfb](80febfb)), closes [#3396](#3396) [#3396](#3396)
* **server:** cleanup import of the removed method ([#3439](#3439)) ([cb1bcbf](cb1bcbf))
* **server:** createPreprocessor was removed ([#3435](#3435)) ([5c334f5](5c334f5))
* **server:** detection new MS Edge Chromium ([#3440](#3440)) ([7166ce2](7166ce2))
* **server:** replace optimist on yargs lib ([#3451](#3451)) ([ec1e69a](ec1e69a)), closes [#2473](#2473)
* **server:** Report original error message ([#3415](#3415)) ([79ee331](79ee331)), closes [#3414](#3414)

### Code Refactoring

* use native Promise instead of Bluebird ([#3436](#3436)) ([33a069f](33a069f)), closes [/github.com//pull/3060#discussion_r284797390](https://github.com//github.com/karma-runner/karma/pull/3060/issues/discussion_r284797390)

### Continuous Integration

* drop node 8, adopt node 12 ([#3430](#3430)) ([a673aa8](a673aa8))

### Features

* **docs:** document `DEFAULT_LISTEN_ADDR` constant ([#3443](#3443)) ([057d527](057d527)), closes [#2479](#2479)
* **karma-server:** added log to the server.js for uncaught exception ([#3399](#3399)) ([adc6a66](adc6a66))
* **preprocessor:** obey Pattern.isBinary when set ([#3422](#3422)) ([708ae13](708ae13)), closes [#3405](#3405)

### BREAKING CHANGES

* Karma plugins which rely on the fact that Karma uses Bluebird promises may break as Bluebird-specific API is no longer available on Promises returned by the Karma core
* **server:** Deprecated createPreprocessor removed, karma-browserify < 7 version doesn't work
* no more testing on node 8.
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@johnjbarton johnjbarton deleted the isbinary branch December 23, 2020 20:13
@karronoli karronoli mentioned this pull request Aug 16, 2022
Merged
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
@semantic-release-bot @anthony-redFox
chore(release): 5.0.0 [skip ci]
d4e245c 
# [5.0.0](karma-runner/karma@v4.4.1...v5.0.0) (2020-04-09)

### Bug Fixes

* install semantic-release as a regular dev dependency ([karma-runner#3455](karma-runner#3455)) ([1eaf35e](karma-runner@1eaf35e))
* **ci:** echo travis env that gates release after_success ([karma-runner#3446](karma-runner#3446)) ([b8b2ed8](karma-runner@b8b2ed8))
* **ci:** poll every 10s to avoid rate limit. ([karma-runner#3388](karma-runner#3388)) ([91e7e00](karma-runner@91e7e00))
* **middleware/runner:** handle file list rejections ([karma-runner#3400](karma-runner#3400)) ([80febfb](karma-runner@80febfb)), closes [karma-runner#3396](karma-runner#3396) [karma-runner#3396](karma-runner#3396)
* **server:** cleanup import of the removed method ([karma-runner#3439](karma-runner#3439)) ([cb1bcbf](karma-runner@cb1bcbf))
* **server:** createPreprocessor was removed ([karma-runner#3435](karma-runner#3435)) ([5c334f5](karma-runner@5c334f5))
* **server:** detection new MS Edge Chromium ([karma-runner#3440](karma-runner#3440)) ([7166ce2](karma-runner@7166ce2))
* **server:** replace optimist on yargs lib ([karma-runner#3451](karma-runner#3451)) ([ec1e69a](karma-runner@ec1e69a)), closes [karma-runner#2473](karma-runner#2473)
* **server:** Report original error message ([karma-runner#3415](karma-runner#3415)) ([79ee331](karma-runner@79ee331)), closes [karma-runner#3414](karma-runner#3414)

### Code Refactoring

* use native Promise instead of Bluebird ([karma-runner#3436](karma-runner#3436)) ([33a069f](karma-runner@33a069f)), closes [/github.com/karma-runner/pull/3060#discussion_r284797390](https://github.com//github.com/karma-runner/karma/pull/3060/issues/discussion_r284797390)

### Continuous Integration

* drop node 8, adopt node 12 ([karma-runner#3430](karma-runner#3430)) ([a673aa8](karma-runner@a673aa8))

### Features

* **docs:** document `DEFAULT_LISTEN_ADDR` constant ([karma-runner#3443](karma-runner#3443)) ([057d527](karma-runner@057d527)), closes [karma-runner#2479](karma-runner#2479)
* **karma-server:** added log to the server.js for uncaught exception ([karma-runner#3399](karma-runner#3399)) ([adc6a66](karma-runner@adc6a66))
* **preprocessor:** obey Pattern.isBinary when set ([karma-runner#3422](karma-runner#3422)) ([708ae13](karma-runner@708ae13)), closes [karma-runner#3405](karma-runner#3405)

### BREAKING CHANGES

* Karma plugins which rely on the fact that Karma uses Bluebird promises may break as Bluebird-specific API is no longer available on Promises returned by the Karma core
* **server:** Deprecated createPreprocessor removed, karma-browserify < 7 version doesn't work
* no more testing on node 8.
This was referenced Jan 1, 2024
Open
Open
@Omrisnyk Omrisnyk mentioned this pull request Feb 2, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Feb 11, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Mar 15, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request May 28, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Jun 19, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Jul 2, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Oct 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyliau kyliau kyliau approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isBinaryFile considers certain protobuf binary files as text
4 participants
@johnjbarton @karmarunnerbot @AppVeyorBot @kyliau