refactor(test): adjust sandbox folder location and simplify config logic #3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build karma 240 completed (commit d382ad4034 by @devoto13) |
|
✅ Build karma 239 completed (commit d382ad4034 by @devoto13) |
johnjbarton
suggested changes
Apr 30, 2020
This is a bit bigger change, but modifications are closely related and I think it makes sense to land them all together.
The main change is in test/e2e/support/world.js file, where all important paths are defined:
- `workDir` is the current working directory for the tested Karma process - `test/e2e/support`. Same as before.
- `sandboxDir` moved from `tmp/sandbox` in the repository root to `test/e2e/support/sandbox`. Sandbox directory is reset before every scenario (see `test/e2e/step_definitions/hooks.js`) and this is where all generated files should be (hence change of paths in `browser_console.feature`). This also makes things cleaner as now all paths in the .feature files are relative to `workDir`.
- `configFile` is path where Karma config file is generated. It no longer contains hash as it was not really needed. It may be re-introduced later if tests are run in parallel, but then it makes more sense to have it as a part of `sandboxDir` instead.
- `karmaExecutable` is an absolute path to the Karma executable.
The change from `__dirname + '/` to `_resolve('` in two .feature files is to avoid having two different hacks to resolve absolute paths.
The last change in this file is to simplify config generation methods.
Remaining changes in `test/e2e/step_definitions/core_steps.js` are adapting steps to the above changes by removing bunch of boilerplate, which is no longer necessary.
|
✅ Build karma 241 completed (commit 22e67110db by @devoto13) |
|
✅ Build karma 240 completed (commit 22e67110db by @devoto13) |
|
@johnjbarton Have no idea why BrowserStack tests failed again... This change should not have affected anything in client tests. Do you have access to any logs or something in the BrowserStack UI? https://travis-ci.org/github/karma-runner/karma/jobs/681994903#L716 |
|
This looks unrelated to your change. I restarted the job. |
|
🎉 This PR is included in version 5.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
anthony-redFox
pushed a commit
to anthony-redFox/karma
that referenced
this pull request
May 16, 2023
…gic (karma-runner#3493) This is a bit bigger change, but modifications are closely related and I think it makes sense to land them all together. The main change is in test/e2e/support/world.js file, where all important paths are defined: - `workDir` is the current working directory for the tested Karma process - `test/e2e/support`. Same as before. - `sandboxDir` moved from `tmp/sandbox` in the repository root to `test/e2e/support/sandbox`. Sandbox directory is reset before every scenario (see `test/e2e/step_definitions/hooks.js`) and this is where all generated files should be (hence change of paths in `browser_console.feature`). This also makes things cleaner as now all paths in the .feature files are relative to `workDir`. - `configFile` is path where Karma config file is generated. It no longer contains hash as it was not really needed. It may be re-introduced later if tests are run in parallel, but then it makes more sense to have it as a part of `sandboxDir` instead. - `karmaExecutable` is an absolute path to the Karma executable. The change from `__dirname + '/` to `_resolve('` in two .feature files is to avoid having two different hacks to resolve absolute paths. The last change in this file is to simplify config generation methods. Remaining changes in `test/e2e/step_definitions/core_steps.js` are adapting steps to the above changes by removing bunch of boilerplate, which is no longer necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit bigger change, but modifications are related and I think it makes sense to land them all together.
The main change is in test/e2e/support/world.js file, where all important paths are defined:
workDiris the current working directory for the tested Karma process -test/e2e/support. Same as before.sandboxDirmoved fromtmp/sandboxin the repository root totest/e2e/support/sandbox. Sandbox directory is reset before every scenario (seetest/e2e/step_definitions/hooks.js) and this is where all generated files should be (hence change of paths inbrowser_console.feature). This also makes things cleaner as now all paths in the .feature files are relative toworkDir.configFileis path where Karma config file is generated. It no longer contains hash as it was not really needed. It may be re-introduced later if tests are run in parallel, but then it makes more sense to have it as a part ofsandboxDirinstead.karmaExecutableis an absolute path to the Karma executable.The change from
__dirname + '/to_resolve('in two .feature files is to avoid having two different hacks to resolve absolute paths.The last change in this file is to simplify config generation methods.
Remaining changes in
test/e2e/step_definitions/core_steps.jsare adapting steps to the above changes by removing bunch of boilerplate, which is no longer necessary.