Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): fix documentation update task #3551

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

devoto13
Copy link
Collaborator

@devoto13 devoto13 commented Sep 1, 2020

The task has never succeeded because there was a typo in the repository URL.
See https://travis-ci.org/github/karma-runner/karma/jobs/722815882#L1324

But build has never failed either, because "The exit code of after_success, after_failure, after_script, after_deploy and subsequent stages do not affect the build result." according to Travis documentation and this code was run in after_success stage. This should be fixed in a separate PR though.

The task has never succeeded because there was a typo in the repository URL.
See https://travis-ci.org/github/karma-runner/karma/jobs/722815882#L1324

But build has never failed either, because "The exit code of after_success, after_failure, after_script, after_deploy and subsequent stages do not affect the build result." according to Travis [documentation](https://docs.travis-ci.com/user/job-lifecycle/#breaking-the-build) and this code was run in `after_success` stage. This should be fixed in a separate PR though.
@karmarunnerbot
Copy link
Member

Build karma 350 completed (commit 40c8d8574d by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 349 completed (commit 40c8d8574d by @devoto13)

@johnjbarton johnjbarton merged commit 4b3a469 into karma-runner:master Sep 2, 2020
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 5.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@devoto13 devoto13 deleted the fix-docs branch September 2, 2020 17:43
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
The task has never succeeded because there was a typo in the repository URL.
See https://travis-ci.org/github/karma-runner/karma/jobs/722815882#L1324

But build has never failed either, because "The exit code of after_success, after_failure, after_script, after_deploy and subsequent stages do not affect the build result." according to Travis [documentation](https://docs.travis-ci.com/user/job-lifecycle/#breaking-the-build) and this code was run in `after_success` stage. This should be fixed in a separate PR though.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants