-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): adjust test to pass in Safari browser #3645
Conversation
In Safari stringified Proxy object has ProxyObject as a name, but in other browsers it does not. Enabled Safari tests on BrowserStack to prevent future regressions.
c149980
to
bde0ed5
Compare
✅ Build karma 517 completed (commit 2f5ac13df4 by @devoto13) |
✅ Build karma 516 completed (commit 2f5ac13df4 by @devoto13) |
✅ Build karma 518 completed (commit 91cc396239 by @devoto13) |
✅ Build karma 517 completed (commit 91cc396239 by @devoto13) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
One thing I would like to understand is why these tests did not fail in a way that we could see the results in Travis? Was that all about the client syntax errors?
@johnjbarton The main problem was a syntax error in Re how to debug it. While a browser session is active on BrowserStack, one can go into their UI, and click "Start interactive session" (or something) on the job page where one can interact with the browser as it was on their own machine (open dev tools, etc) and figure out if there are any errors in the browser. |
Yeah, and this specific change is because I switched from Safari 9.0 (ancient version) to the latest Safari 14.0, which supports |
🎉 This PR is included in version 6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
In Safari stringified Proxy object has ProxyObject as a name, but in other browsers it does not. Enabled Safari tests on BrowserStack to prevent future regressions.
In Safari stringified Proxy object has ProxyObject as a name, but in other browsers it does not.
Enabled Safari tests on BrowserStack to prevent future regressions.