Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): adjust test to pass in Safari browser #3645

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

devoto13
Copy link
Collaborator

@devoto13 devoto13 commented Feb 1, 2021

In Safari stringified Proxy object has ProxyObject as a name, but in other browsers it does not.

Enabled Safari tests on BrowserStack to prevent future regressions.

@devoto13 devoto13 requested a review from johnjbarton February 1, 2021 20:05
In Safari stringified Proxy object has ProxyObject as a name, but in other browsers it does not.

Enabled Safari tests on BrowserStack to prevent future regressions.
@karmarunnerbot
Copy link
Member

Build karma 517 completed (commit 2f5ac13df4 by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 516 completed (commit 2f5ac13df4 by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 518 completed (commit 91cc396239 by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 517 completed (commit 91cc396239 by @devoto13)

Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

One thing I would like to understand is why these tests did not fail in a way that we could see the results in Travis? Was that all about the client syntax errors?

@johnjbarton johnjbarton merged commit a14a24e into karma-runner:master Feb 2, 2021
@devoto13
Copy link
Collaborator Author

devoto13 commented Feb 2, 2021

@johnjbarton The main problem was a syntax error in socket.io.js client code. That's why a browser was not able to connect back to the server and communicate any information.

Re how to debug it. While a browser session is active on BrowserStack, one can go into their UI, and click "Start interactive session" (or something) on the job page where one can interact with the browser as it was on their own machine (open dev tools, etc) and figure out if there are any errors in the browser.

@devoto13
Copy link
Collaborator Author

devoto13 commented Feb 2, 2021

Yeah, and this specific change is because I switched from Safari 9.0 (ancient version) to the latest Safari 14.0, which supports Proxy. So this test didn't run before, but it does now.

@devoto13 devoto13 deleted the enable-safari branch February 2, 2021 09:54
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants