Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: patch karma to allow loading virtual packages #3663

Merged
merged 2 commits into from
Mar 8, 2021
Merged

fix: patch karma to allow loading virtual packages #3663

merged 2 commits into from
Mar 8, 2021

Conversation

charlessuh
Copy link
Contributor

Based on #3531 from @snasirca

@google-cla
Copy link

google-cla bot commented Mar 8, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@karmarunnerbot
Copy link
Member

✅ Build karma 548 completed (commit ec62029822 by @charlessuh)

@AppVeyorBot
Copy link

✅ Build karma 2945 completed (commit ec62029822 by @charlessuh)

@karmarunnerbot
Copy link
Member

✅ Build karma 547 completed (commit ec62029822 by @charlessuh)

devoto13
devoto13 approved these changes Mar 8, 2021
View reviewed changes
Copy link
Collaborator

@devoto13 devoto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this 👍

@devoto13 devoto13 requested a review from johnjbarton March 8, 2021 20:50
@johnjbarton johnjbarton merged commit 5bfcf5f into karma-runner:master Mar 8, 2021
@johnjbarton johnjbarton mentioned this pull request Mar 8, 2021
Closed
karmarunnerbot pushed a commit that referenced this pull request Mar 9, 2021
@semantic-release-bot
chore(release): 6.1.2 [skip ci]
10afab1 
## [6.1.2](v6.1.1...v6.1.2) (2021-03-09)

### Bug Fixes

* **commitlint:** skip task on master ([#3650](#3650)) ([3fc6fda](3fc6fda))
* patch karma to allow loading virtual packages ([#3663](#3663)) ([5bfcf5f](5bfcf5f))
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 6.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Mar 9, 2021
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
@devoto13 devoto13 mentioned this pull request Mar 9, 2021
Closed
This was referenced Mar 9, 2021
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 15, 2021
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@karronoli karronoli mentioned this pull request Aug 16, 2022
Merged
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
@charlessuh @snasirca @anthony-redFox
fix: patch karma to allow loading virtual packages (karma-runner#3663)
234f5e4 
* fix: patch karma to allow loading virtual packages

* fix: additional patch to handle SCRIPT_URL_ARRAY

Co-authored-by: Shahriyar Nasir <contact@snasir.ca>
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
@semantic-release-bot @anthony-redFox
chore(release): 6.1.2 [skip ci]
db875de 
## [6.1.2](karma-runner/karma@v6.1.1...v6.1.2) (2021-03-09)

### Bug Fixes

* **commitlint:** skip task on master ([karma-runner#3650](karma-runner#3650)) ([3fc6fda](karma-runner@3fc6fda))
* patch karma to allow loading virtual packages ([karma-runner#3663](karma-runner#3663)) ([5bfcf5f](karma-runner@5bfcf5f))
@PDSSnyk PDSSnyk mentioned this pull request May 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoto13 devoto13 devoto13 approved these changes

@johnjbarton johnjbarton Awaiting requested review from johnjbarton

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@charlessuh @karmarunnerbot @AppVeyorBot @devoto13 @johnjbarton @snasirca