Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lfx] Develop Override policy, Resource Binding, Work Page #15

Open
chinmaym07 opened this issue May 7, 2022 · 15 comments
Open

[lfx] Develop Override policy, Resource Binding, Work Page #15

chinmaym07 opened this issue May 7, 2022 · 15 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@chinmaym07
Copy link

chinmaym07 commented May 7, 2022

What would you like to be added:

Develop & enhance the Override Policy, Resource Binding, Work Pages for the Dashboard Project.

Figma Design:

https://www.figma.com/file/nAhWBN06v6hMCHDlIT9mzk/KARMADA?node-id=6%3A132

Why is this needed:
These pages on the web dashboard will help to perform different operations for Override policies, Resource Binding in karmada.

@chinmaym07 chinmaym07 added the kind/feature Categorizes issue or PR as related to a new feature. label May 7, 2022
@Neelesh2512
Copy link

Neelesh2512 commented May 10, 2022

Screenshot from 2022-05-10 20-57-03
@chinmaym07 @RainbowMango I wish to contribute to this under the LFX mentorship program for the summer season. But before that I have a few questions regarding this project as mentioned below:

  • I was checking the given Figma link but it seems like the provided file is missing. But I have checked other pages on Figma like the Login page and About page.
  • Do we have to Design the Override policy, Resource Binding, and Work Page also, or only have to develop them?
  • Do we have to deal with the backend also?

@Prakhar-Jaju
Copy link

@Neelesh2512 same problem with me too, @chinmaym07 @RainbowMango please help us.

@chinmaym07
Copy link
Author

chinmaym07 commented May 12, 2022

Hi @Neelesh2512, @Prakhar-Jaju Thankyou for showing interest 💯.
I have created the figma designs for Override policy, Resource Binding, and Work Page design is in progress. For these you'll have to develop these pages & enhance the existing designs in any way like UX or UI, write unit tests.

I have edited the figma file permissions. Everyone will be able to access it now.

AFAIK most of the work will be using the API's provided by the kamada for different functionalities like login, CRUD operations for different type of resources. So you'll have to get a better understanding of the API's that you are using.

@Neelesh2512
Copy link

@chinmaym07 Thank you for the response. Right now I am going through the codebase of the project. After that, I will apply for the same on the LFX mentorship portal.

@Taiwrash
Copy link

This also interest me and I will love to be part of this.

@RainbowMango
Copy link
Member

/assign @ada2468

@karmada-bot
Copy link
Collaborator

@RainbowMango: GitHub didn't allow me to assign the following users: ada2468.

Note that only karmada-io members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @ada2468

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Taiwrash
Copy link

Hi managers,

If it is possible that I can be added or assigned to this task. I am available to take it up!

Best,
Rasheed.

@ada2468
Copy link

ada2468 commented Jul 14, 2022

@RainbowMango karmada-bot said I need to comment to be assignee. Well, here is the comment. :D

@RainbowMango
Copy link
Member

If it is possible that I can be added or assigned to this task. I am available to take it up!

Sure, you definitely can join and work with @ada2468 on this task.
But I need to be clear in advance that the window of the LFX-summer project now has been closed, so no badge and no payment for it.

@RainbowMango
Copy link
Member

/assign @ada2468

@Taiwrash
Copy link

If it is possible that I can be added or assigned to this task. I am available to take it up!

Sure, you definitely can join and work with @ada2468 on this task. But I need to be clear in advance that the window of the LFX-summer project now has been closed, so no badge and no payment for it.

Sure I will be glad to join the person on the project. What's the next process?

@RainbowMango
Copy link
Member

Sure I will be glad to join the person on the project. What's the next process?

@ada2468 Please update the status here.

@ada2468
Copy link

ada2468 commented Jul 15, 2022

If it is possible that I can be added or assigned to this task. I am available to take it up!

Sure, you definitely can join and work with @ada2468 on this task. But I need to be clear in advance that the window of the LFX-summer project now has been closed, so no badge and no payment for it.

Sure I will be glad to join the person on the project. What's the next process?

@Taiwrash You are more than welcome! Here is current status.

The big plan for now is to work on component level:

  1. identify the components needed for our pages;
  2. develop the components;
  3. test it and create a PR following this GitHub workflow guideline.

Right now, I'm working on UI components and MUI theme. Besides UI, this issue also needs some work on designing a redux store, write code to handle frontend-backend communication, like implementing redux-saga/thunk and APIs for fetching data from Karmada go server. The current progress is still at early stage, you could start on anything as you see fit. To avoid massive merge conflicts in the future, it's desired to have your code loosely-coupled with others and also please create small PRs.

@Taiwrash
Copy link

If it is possible that I can be added or assigned to this task. I am available to take it up!

Sure, you definitely can join and work with @ada2468 on this task. But I need to be clear in advance that the window of the LFX-summer project now has been closed, so no badge and no payment for it.

Sure I will be glad to join the person on the project. What's the next process?

@Taiwrash You are more than welcome! Here is current status.

The big plan for now is to work on component level:

  1. identify the components needed for our pages;
  2. develop the components;
  3. test it and create a PR following this GitHub workflow guideline.

Right now, I'm working on UI components and MUI theme. Besides UI, this issue also needs some work on designing a redux store, write code to handle frontend-backend communication, like implementing redux-saga/thunk and APIs for fetching data from Karmada go server. The current progress is still at early stage, you could start on anything as you see fit. To avoid massive merge conflicts in the future, it's desired to have your code loosely-coupled with others and also please create small PRs.

Thanks @ada2468 for your response. Can you create a development kit to avoid outright conflict? We can focus on only resolving features suggestions and conflicts caused.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

7 participants