-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue #24: Manually Generate Secret for K8s v1.24+ #30
base: ng-dashboard-react
Are you sure you want to change the base?
Fix Issue #24: Manually Generate Secret for K8s v1.24+ #30
Conversation
Signed-off-by: Jun Xiang <jx2161@nyu.edu>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@RainbowMango |
Signed-off-by: Jun Xiang <jx2161@nyu.edu>
2498715
to
c15eaae
Compare
Signed-off-by: Jun Xiang <jx2161@nyu.edu>
a3a66d1
to
126467c
Compare
What type of PR is this?
/kind bug
What this PR does / why we need it:
The background story is that since K8s v1.24+, service account by default doesn't create secret automatically. As the result, if we follow the old instruction, we can't get a login token, because there is no secret present.
Potential Solutions:
More discussion can be found here:
karmada-io/karmada#1961
karmada-io/karmada#1972
https://itnext.io/big-change-in-k8s-1-24-about-serviceaccounts-and-their-secrets-4b909a4af4e0
My Solution:
The second one. This assumes you use k8s v1.24+.
Add instruction in README.me for modifying karmada-dashboard-role.yaml, to manually create secret for us to see the login token. Then we can login the dashboard.
Which issue(s) this PR fixes:
Fixes #24
Signed-off-by: Jun Xiang jx2161@nyu.edu