Fix Issue #24: Manually Generate Secret for K8s v1.24+ #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jun Xiang <jx2161@nyu.edu>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
size/M
|
@RainbowMango |
Signed-off-by: Jun Xiang <jx2161@nyu.edu>
ada2468
force-pushed
the
Fix-for-no-secret-autogen
branch
from
2498715
to
c15eaae
Compare
Signed-off-by: Jun Xiang <jx2161@nyu.edu>
ada2468
force-pushed
the
Fix-for-no-secret-autogen
branch
from
a3a66d1
to
126467c
Compare
ada2468
changed the title
|
I use your yaml, but can not create secret
it is very unbelievable |
|
I test find the secret dashboardsecret is deleted immediately after created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The background story is that since K8s v1.24+, service account by default doesn't create secret automatically. As the result, if we follow the old instruction, we can't get a login token, because there is no secret present.
Potential Solutions:
More discussion can be found here:
karmada-io/karmada#1961
karmada-io/karmada#1972
https://itnext.io/big-change-in-k8s-1-24-about-serviceaccounts-and-their-secrets-4b909a4af4e0
My Solution:
The second one. This assumes you use k8s v1.24+.
Add instruction in README.me for modifying karmada-dashboard-role.yaml, to manually create secret for us to see the login token. Then we can login the dashboard.
Which issue(s) this PR fixes:
Fixes #24
Signed-off-by: Jun Xiang jx2161@nyu.edu