Added usePagination CustomHook and TableWithPagination component #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ShwetKhatri2001 <19dcs001@lnmiit.ac.in>
karmada-bot
added
the
kind/feature
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
size/L
chinmaym07
reviewed
Sep 11, 2022
There was a problem hiding this comment.
Great work done on this Pagination & Data component. @ShwetKhatri2001 💯
|
@chinmaym07 Do you think this PR is ready to move forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR includes a reusable function/custom-hook to generate pagination for all types of data on different pages. Also, it includes an example of how to include it with data. The example shows how table data can be divided into pages and shown dynamically based on the page number. It is the implementation of this Figma Design ( Overview Page - iteration 7 frame ).
This PR is also using the DataTable component included in the last PR with some modifications to attach pagination for data in a table.
Which issue(s) this PR fixes:
It's a general component useful for different pages of the entire application.
Special notes for your reviewer:
@RainbowMango I'm attaching a preview and video link to show how the functionality of pagination included with the table works. We can use the pagination component similarly on any page for any usecase in future.
Video : https://www.loom.com/share/a1ab8e5047a74535a6cb601a2c99295d
Does this PR introduce a user-facing change?:
Signed-off-by: ShwetKhatri2001 19dcs001@lnmiit.ac.in