Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize Scheduling Policy Management #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kunTom
Copy link

@kunTom kunTom commented Jan 7, 2023

Signed-off-by: Thomson kun.tang@daocloud.io

What type of PR is this?

  1. Optimize the field display and remove the status field at the same time, because there is no status field in the data returned by the API
  2. The getDistributionList function is optimized, because some fields may be empty, and the KIND type is specified at the same time, because the requested API has already specified the KIND type, so the ternary operation is removed

Signed-off-by: Thomson <kun.tang@daocloud.io>
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rainbowmango after the PR has been reviewed.
You can assign the PR to them by writing /assign @rainbowmango in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants