Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add proposal for web-terminal #55

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

warjiang
Copy link
Contributor

What type of PR is this?
/kind design

What this PR does / why we need it:
Through web-terminal we can provie standard environment and useful tools for dashboard end-users, make it easily to experience karmada.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/design Categorizes issue or PR as related to design. label Jul 10, 2024
Signed-off-by: warjiang <1096409085@qq.com>
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 10, 2024
@warjiang
Copy link
Contributor Author

/assign @samzong @RainbowMango

Signed-off-by: warjiang <1096409085@qq.com>
Copy link
Member

@samzong samzong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great ~

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samzong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024
@warjiang
Copy link
Contributor Author

great ~

It seems that we need an extra lgtm label ~

@RainbowMango RainbowMango added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 22, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Here we go.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2024
@karmada-bot karmada-bot merged commit c81bdec into karmada-io:main Jul 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/design Categorizes issue or PR as related to design. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants