Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/turborepo #56

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

warjiang
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:

  1. implement @karmada/terminal and corresponding addon(zmodem and overlay addon)
  2. introduce turborepo, which is very useful to solve the dependency tree under the ui folder
  3. introduce changeset to gen changelog for ui components under the ui/packages folder

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

1. implement @karmada/terminal and corresponding addon(zmodem and overlay addon)
2. introduce turborepo and changeset tools

@karmada-bot karmada-bot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Jul 10, 2024
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 10, 2024
@warjiang
Copy link
Contributor Author

/assign @samzong

@karmada-bot karmada-bot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 10, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from samzong. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RainbowMango
Copy link
Member

@warjiang Is this ready to move forward? Would you like to rebase, since this PR has been waiting for a while, I don't know if it still passes the CI tests.

@warjiang
Copy link
Contributor Author

@warjiang Is this ready to move forward? Would you like to rebase, since this PR has been waiting for a while, I don't know if it still passes the CI tests.

I'll rebase and recheck this PR locally. Need more time~

@RainbowMango
Copy link
Member

OK. no rush, take your time, just assign it to me once you are ready.

Signed-off-by: warjiang <1096409085@qq.com>
Signed-off-by: warjiang <1096409085@qq.com>
Signed-off-by: warjiang <1096409085@qq.com>
Signed-off-by: warjiang <1096409085@qq.com>
Signed-off-by: warjiang <1096409085@qq.com>
Signed-off-by: warjiang <1096409085@qq.com>
Signed-off-by: warjiang <1096409085@qq.com>
Signed-off-by: warjiang <1096409085@qq.com>
Signed-off-by: warjiang <1096409085@qq.com>
@warjiang
Copy link
Contributor Author

@RainbowMango I've rebase the code and re-check the build ci, plz check it again.

@warjiang
Copy link
Contributor Author

@RainbowMango I've rebase the code and re-check the build ci, plz check it again.

the PR is still large, do I need to split it into multi PRs. Some background is that the feature of this PR(turborepo and ui components) can work standalone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants