fix When EnableEmptyWorkloadPropagation flag is false zero deployment…

… still can be propagated to member cluster

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>

pkg/scheduler/core/division_algorithm_test.go

@@ -84,6 +84,22 @@ func Test_dispenser_takeByWeight(t *testing.T) {
 			},
 			done: true,
 		},
+		{
+			name:        "remove zero replicas",
+			numReplicas: 2,
+			result:      []workv1alpha2.TargetCluster{},
+			weightList: []utilhelper.ClusterWeightInfo{
+				{ClusterName: "A", Weight: 1},
+				{ClusterName: "B", Weight: 1},
+				{ClusterName: "C", Weight: 1},
+				{ClusterName: "D", Weight: 1},
+			},
+			desired: []workv1alpha2.TargetCluster{
+				{Name: "A", Replicas: 1},
+				{Name: "B", Replicas: 1},
+			},
+			done: true,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {

pkg/util/helper/binding.go

@@ -111,14 +111,20 @@ func (a *Dispenser) TakeByWeight(w ClusterWeightInfoList) {
 		remain -= replicas
 	}
 	// TODO(Garrybest): take rest replicas by fraction part
-	for i := range result {
-		if remain == 0 {
-			break
+	for i, removed, resultLen := 0, 0, len(result); i < resultLen; i++ {
+		j := i - removed
+		if remain != 0 {
+			result[j].Replicas++
+			remain--
+			continue
+		}
+		// when the replicas of a scheduling result is zero,
+		// it should not be propagated to member cluster.
+		if result[j].Replicas == 0 {
+			result = append(result[:j], result[j+1:]...)
+			removed++
 		}
-		result[i].Replicas++
-		remain--
 	}
-
 	a.NumReplicas = remain
 	a.Result = util.MergeTargetClusters(a.Result, result)
 }