Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to Support dynamically adding overriders #1567

Closed
CharlesQQ opened this issue Mar 31, 2022 · 0 comments · Fixed by #5118
Closed

How to Support dynamically adding overriders #1567

CharlesQQ opened this issue Mar 31, 2022 · 0 comments · Fixed by #5118
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@CharlesQQ
Copy link
Contributor

CharlesQQ commented Mar 31, 2022

What would you like to be added:
We have a custom controller for Annotation-based gray code release; The different code release batch for cluster has the different metedata.annotation value, the value needs to be dynamically added in the overridepolicy and it's changed for each code release batch;

Why is this needed:
Support to dynamically add and complete this part of overriders before the work object is generated. I think of two ways to achieve this:

  1. Add a new type of interpreter webhook
  2. Allow user-defined controllers to watch overridepolicy's create/update events, and dynamically patch overriders, but it needs to be done before the work object is generated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
1 participant