feat: pause ensure work object #2165
Conversation
karmada-bot
added
the
kind/feature
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
size/L
CharlesQQ
force-pushed
the
karmada-paused-impl
branch
2 times, most recently
from
29d40e2
to
b06f5ae
Compare
| @@ -116,6 +116,9 @@ const ( | |||
| // Only necessary for those resource types that have dependencies resources and expect the dependencies be propagated | |||
| // together, like Deployment depends on ConfigMap/Secret. | |||
| InterpreterOperationInterpretDependency InterpreterOperation = "InterpretDependency" | |||
|
|
|||
| // InterpreterOperationPauseEnsureWork indicates that karmada want to judge whether pause ensure work object or not. | |||
| InterpreterOperationPauseEnsureWork InterpreterOperation = "PauseEnsureWork" | |||
There was a problem hiding this comment.
Do you need to update the document?
| return true | ||
| } | ||
| } | ||
| return false |
There was a problem hiding this comment.
| return false | |
| return labels != nil && labels[PauseEnsureWorkLabels] == True |
Signed-off-by: charlesQQ <charles_ali@qq.com>
CharlesQQ
force-pushed
the
karmada-paused-impl
branch
from
b06f5ae
to
4f0a052
Compare
|
Hi @CharlesQQ in favor of #5217, can we close this pr? |
|
/close |
|
@CharlesQQ: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: charlesQQ charles_ali@qq.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1567
Special notes for your reviewer:
Does this PR introduce a user-facing change?: