Propose donot delete namespace when karmadactl deinit

[hzxuzhonghu]

What would you like to be added:

I installed karmada in a private namespace which has many other resource objects that donot belong to karmada.

However when i uinstall with kubectl-karmda deinit -n , my namespace is also deleted, which is not expected.

Looking into istio, it also use istioctl uninstall, but after it uninstall, the namespace is still there. Deleting a namespace can be terrible, i think this option should be given back to user.

[XiShanYongYe-Chang]

It makes sense, maybe we can consider adding an option to control.
Ask the module owner to help take a look.

/cc @lonelyCZ @carlory

[lonelyCZ]

It makes sense, we only set a option here. I will add it.

karmada/pkg/karmadactl/deinit/deinit.go

Lines 145 to 152 in 5194e17

	// Delete namespace where Karmada components are installed
	fmt.Printf("delete Namespace %q\n", o.Namespace)
	if o.DryRun {
	return nil
	}
	if err = o.KubeClientSet.CoreV1().Namespaces().Delete(context.Background(), o.Namespace, metav1.DeleteOptions{}); err != nil {
	return err
	}

/assign

[RainbowMango]

@lonelyCZ Please take a look at #3326, seems the same issue.

[lonelyCZ]

@lonelyCZ Please take a look at #3326, seems the same issue.

Oh, I missed it. Let't continue to #3326 .

[RainbowMango]

In my opinion, if we can recognize that the namespace was created by Karmada, then we have the confidence to remove it during deinit by default, (relying #2862).
But also glad to have the option/flag to reserve the namespace from deleting.

[lonelyCZ]

This has be resolved by #3326

/close

[karmada-bot]

@lonelyCZ: Closing this issue.

In response to this:

This has be resolved by #3326

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.