Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix karmada-bot /retest #3421

Closed
helen-frank opened this issue Apr 18, 2023 · 14 comments
Closed

Fix karmada-bot /retest #3421

helen-frank opened this issue Apr 18, 2023 · 14 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@helen-frank
Copy link
Contributor

What would you like to be added:
Fix karmada-bot /retest
Why is this needed:
Accelerated PR test

@helen-frank helen-frank added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 18, 2023
@helen-frank
Copy link
Contributor Author

@RainbowMango Do you have time to repair the karmada-bot /retest function? It has been broken for a long time.😂

@RainbowMango
Copy link
Member

It's not broken, it's never working~

The robot command /retest is used to trigger the tests managed by prombot, but Karmada's tests are managed by GitHub Action, I don't think a robot can do that.

@helen-frank
Copy link
Contributor Author

It's not broken, it's never working~

The robot command /retest is used to trigger the tests managed by prombot, but Karmada's tests are managed by GitHub Action, I don't think a robot can do that.

emmm, I haven't actually used github action, so I'm not quite sure what's going on here, except to see that other communities are available

@whitewindmills
Copy link
Member

+1
It's cool if the command /retest is available.

@RainbowMango
Copy link
Member

+1
But I don't know what to do :(

@liangyuanpeng
Copy link
Contributor

/assign

@RainbowMango
Copy link
Member

I'm going to close this issue for now as we don't have an ideal solution yet.

Now we should focus on building a stable testing environment.
/close

@karmada-bot
Copy link
Collaborator

@RainbowMango: Closing this issue.

In response to this:

I'm going to close this issue for now as we don't have an ideal solution yet.

Now we should focus on building a stable testing environment.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liangyuanpeng
Copy link
Contributor

liangyuanpeng commented Oct 8, 2023

After my testing on prow, the current prow already supports the retest operation on github action.

here is my config for it:

apiVersion: v1
kind: ConfigMap
metadata:
  namespace: prow
  name: plugins
data:
  plugins.yaml: |
    triggers:
    - repos:
      - liangyuanpeng/liangyuanpeng.github.io
      - liangyuanpeng/jxline 
      only_org_members: true
      trigger_github_workflows: true
...

Just add configuration of trigger_github_workflows: true and it's working. It will rerun failed workflow.

Check the PR of prow: kubernetes/test-infra#25736

@RainbowMango

@RainbowMango
Copy link
Member

Fantastic! Which image version you are using? By the way, do you know where I can find all available prow images?

@liangyuanpeng
Copy link
Contributor

liangyuanpeng commented Oct 9, 2023

@RainbowMango

Which image version you are using

I have tested it with latest and v20220105-8e97316bf9 :) Here is the more info for it.

This feature was introduced by this PR kubernetes/test-infra#24726 , and the corresponding prow image version is: v20220105-8e97316bf9, This is the minimum prow version that you want to use /retest for github action. The format is {date}-{shortcommit}

There is a known issue with /retest which seems to have some issues with PRs submitted by the dependabot

do you know where I can find all available prow images?

I just check it in https://console.cloud.google.com/gcr/images/k8s-prow , seems like the prow have not this message about release version.

@RainbowMango
Copy link
Member

Hi @liangyuanpeng I just launched another prow instance with v20240216-16ababd181. I opened #4637 to track the migration process.

@RainbowMango RainbowMango modified the milestones: v1.9, v1.10 Feb 29, 2024
@RainbowMango
Copy link
Member

/close

the command /retest gets on board now.

@karmada-bot
Copy link
Collaborator

@RainbowMango: Closing this issue.

In response to this:

/close

the command /retest gets on board now.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants