Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cluster-api to v1.5.0 #3932

Closed
RainbowMango opened this issue Aug 11, 2023 · 1 comment · Fixed by #3934
Closed

Update cluster-api to v1.5.0 #3932

RainbowMango opened this issue Aug 11, 2023 · 1 comment · Fixed by #3934
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@RainbowMango
Copy link
Member

Task description:

Currently, we are using sigs.k8s.io/cluster-api v1.5.0-rc.0 which is only for testing purposes.
We have to update it to the latest v1.5.0.

Solution:

We can update the go.mod manually, then run make update under the root of the repo and commit all generated files.

diff --git a/go.mod b/go.mod
index 182a00043..ba2099556 100644
--- a/go.mod
+++ b/go.mod
@@ -47,7 +47,7 @@ require (
        k8s.io/metrics v0.27.3
        k8s.io/utils v0.0.0-20230406110748-d93618cff8a2
        layeh.com/gopher-json v0.0.0-20201124131017-552bb3c4c3bf
-       sigs.k8s.io/cluster-api v1.5.0-rc.0
+       sigs.k8s.io/cluster-api v1.5.0
        sigs.k8s.io/controller-runtime v0.15.0
        sigs.k8s.io/custom-metrics-apiserver v1.27.0

Who can join or take the task:

The good first issue is intended for first-time contributors to get started on his/her contributor journey.

After a contributor has successfully completed 1-2 good first issue's,
they should be ready to move on to help wanted items, saving the remaining good first issue for other new contributors.

How to join or take the task:

Just reply on the issue with the message /assign in a separate line.

Then, the issue will be assigned to you.

How to ask for help:

If you need help or have questions, please feel free to ask on this issue.
The issue author or other members of the community will guide you through the contribution process.

@RainbowMango RainbowMango added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Aug 11, 2023
@parthn2
Copy link
Contributor

parthn2 commented Aug 11, 2023

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants