Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed sigs.k8s.io/cluster-api v1.5.0-rc.0 to v1.5.0 #3934

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

parthn2
Copy link
Contributor

@parthn2 parthn2 commented Aug 11, 2023

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Updates the cluster-api version

Which issue(s) this PR fixes:
Fixes #3932

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 11, 2023
@RainbowMango
Copy link
Member

Looks good, but you might need to sign the DCO:https://github.com/karmada-io/karmada/pull/3934/checks?check_run_id=15816626820

@codecov-commenter
Copy link

Codecov Report

Merging #3934 (766e8a9) into master (6dea121) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #3934   +/-   ##
=======================================
  Coverage   54.70%   54.70%           
=======================================
  Files         229      229           
  Lines       22074    22074           
=======================================
  Hits        12076    12076           
  Misses       9352     9352           
  Partials      646      646           
Flag Coverage Δ
unittests 54.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Parth Nanda <parthnanda002@gmail.com>
@parthn2
Copy link
Contributor Author

parthn2 commented Aug 11, 2023

Looks good, but you might need to sign the DCO:https://github.com/karmada-io/karmada/pull/3934/checks?check_run_id=15816626820

Oh sorry! I forgot to do that, I signed it off now. Thanks

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangyuanpeng, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@karmada-bot karmada-bot merged commit 22d4636 into karmada-io:master Aug 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update cluster-api to v1.5.0
6 participants