Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop update krew for release 1.6 #4019

Closed
RainbowMango opened this issue Sep 3, 2023 · 3 comments
Closed

Stop update krew for release 1.6 #4019

RainbowMango opened this issue Sep 3, 2023 · 3 comments
Assignees
@whitewindmills
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@RainbowMango
Copy link
Member

What would you like to be added:
Remove update-krew-index from branch release-1.6.

Why is this needed:
Since krew only caches the latest release, so we don't need to update it for v1.6.x releases. Otherwise, it will open an invalid PR, like kubernetes-sigs/krew-index#2809.

Sample PR: #3629
@RainbowMango RainbowMango added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Sep 3, 2023
@whitewindmills
Copy link
Member

I'd like to do it.
/assign

@whitewindmills whitewindmills mentioned this issue Sep 4, 2023
Merged
@whitewindmills
Copy link
Member

/close

@karmada-bot
Copy link
Collaborator

@whitewindmills: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whitewindmills whitewindmills

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RainbowMango @karmada-bot @whitewindmills