Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to sync labels correctly #4781

Closed
whitewindmills opened this issue Mar 30, 2024 · 1 comment · Fixed by #4784
Closed

Unable to sync labels correctly #4781

whitewindmills opened this issue Mar 30, 2024 · 1 comment · Fixed by #4784
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@whitewindmills
Copy link
Member

What happened:
I created a resource template to propagate to member clusters, but cannot delete any label which already exists via Karmada.

ConfigMap of Karmada control-plane

image

ConfigMap of Member clusters

image

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

  1. Create any resource to propagate to member clusters.
  2. Add any label to your resource via Karmada.
  3. Delete the label via Karmada.

Anything else we need to know?:
I found the propagated resource is missing the annotation resourcetemplate.karmada.io/managed-labels, and the annotation was mistakenly added to the work object.
image

Environment:

  • Karmada version:
  • kubectl-karmada or karmadactl version (the result of kubectl-karmada version or karmadactl version):
  • Others:
@whitewindmills whitewindmills added the kind/bug Categorizes issue or PR as related to a bug. label Mar 30, 2024
@whitewindmills
Copy link
Member Author

I've figured out the source of this problem, it was introduced by #4199.
image

/assign
cc @XiShanYongYe-Chang @RainbowMango

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant