Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add resource id label #4199

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

jwcesign
Copy link
Member

@jwcesign jwcesign commented Oct 31, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:
Referring to #4000

Which issue(s) this PR fixes:
Part of #4000

Special notes for your reviewer:
none

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: Introduced permanent ID to PropagationPolicy, ClusterPropagationPolicy, ResourceBinding, ClusterResourceBinding, and Work.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 31, 2023
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 31, 2023
@jwcesign jwcesign force-pushed the add-id-label branch 2 times, most recently from 9c00889 to 8943b2e Compare November 1, 2023 06:16
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

Attention: 104 lines in your changes are missing coverage. Please review.

Comparison is base (d6e2881) 52.79% compared to head (7e6387e) 52.66%.
Report is 26 commits behind head on master.

Files Patch % Lines
pkg/detector/detector.go 0.00% 76 Missing ⚠️
...ependenciesdistributor/dependencies_distributor.go 0.00% 18 Missing ⚠️
pkg/util/helper/work.go 0.00% 5 Missing ⚠️
pkg/detector/preemption.go 0.00% 3 Missing ⚠️
...hpareplicassyncer/hpa_replicas_syncer_predicate.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4199      +/-   ##
==========================================
- Coverage   52.79%   52.66%   -0.14%     
==========================================
  Files         239      240       +1     
  Lines       23584    23692     +108     
==========================================
+ Hits        12452    12478      +26     
- Misses      10456    10535      +79     
- Partials      676      679       +3     
Flag Coverage Δ
unittests 52.66% <14.04%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwcesign jwcesign force-pushed the add-id-label branch 2 times, most recently from 38965d7 to 6a2dfa0 Compare November 7, 2023 07:13
@jwcesign
Copy link
Member Author

jwcesign commented Nov 7, 2023

Testing result:
https://docs.google.com/document/d/1bEOBAvdBuqTeETDHfBdTJ0nyy0s-s5Mue_BZgAlMmy0/edit?usp=sharing

/cc @XiShanYongYe-Chang @chaosi-zju
Can you review the modification when you have time?

@XiShanYongYe-Chang
Copy link
Member

/assign

pkg/detector/detector.go Outdated Show resolved Hide resolved
pkg/apis/policy/v1alpha1/well_known_constants.go Outdated Show resolved Hide resolved
@jwcesign jwcesign changed the title feat: add resoruce id label feat: add resource id label Nov 10, 2023
pkg/util/label.go Outdated Show resolved Hide resolved
Signed-off-by: jwcesign <jwcesign@gmail.com>
Copy link
Member

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

/lgtm

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2023
@karmada-bot karmada-bot merged commit 55547b2 into karmada-io:master Nov 23, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants