-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add resource id label #4199
Conversation
pkg/controllers/hpareplicassyncer/hpa_replicas_syncer_predicate.go
Outdated
Show resolved
Hide resolved
9c00889
to
8943b2e
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4199 +/- ##
==========================================
- Coverage 52.79% 52.66% -0.14%
==========================================
Files 239 240 +1
Lines 23584 23692 +108
==========================================
+ Hits 12452 12478 +26
- Misses 10456 10535 +79
- Partials 676 679 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
38965d7
to
6a2dfa0
Compare
Testing result: /cc @XiShanYongYe-Chang @chaosi-zju |
/assign |
6a2dfa0
to
0e7c52f
Compare
Signed-off-by: jwcesign <jwcesign@gmail.com>
0e7c52f
to
7e6387e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Referring to #4000
Which issue(s) this PR fixes:
Part of #4000
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?: