Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update controller-gen version from v0.13.0 to v0.14.0 #4873

Closed
seanlaii opened this issue Apr 26, 2024 · 5 comments · Fixed by #4874
Closed

Update controller-gen version from v0.13.0 to v0.14.0 #4873

seanlaii opened this issue Apr 26, 2024 · 5 comments · Fixed by #4874
Assignees
@seanlaii
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@seanlaii
Copy link
Contributor

Task description:

We need to bump the controller-gen version to v0.14.0 when we upgrade Go version to v1.22 to avoid this issue.
@seanlaii seanlaii added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 26, 2024
@seanlaii seanlaii mentioned this issue Apr 26, 2024
Closed
2 tasks
@XiShanYongYe-Chang
Copy link
Member

Good job, thanks.

If you were willing to claim this task, you can assign it to yourself.

@seanlaii
Copy link
Contributor Author

Sure, I'd be happy to take on this task when upgrading to Go version 1.22. Thanks!

@RainbowMango
Copy link
Member

RainbowMango commented Apr 26, 2024 •
edited
Loading

Thanks for the notice. I wonder if the controller-gen@v0.14.x can work with Go 1.21?

@seanlaii seanlaii mentioned this issue Apr 26, 2024
Merged
@seanlaii
Copy link
Contributor Author

seanlaii commented Apr 26, 2024 •
edited
Loading

It seems to work. I created a PR for upgrading it. Thanks!

@seanlaii seanlaii changed the title Update controller-gen version from v0.13.0 to v0.14.0 when we upgrade Go version to v1.22 Update controller-gen version from v0.13.0 to v0.14.0 Apr 27, 2024
@XiShanYongYe-Chang
Copy link
Member

In favor of #4874
/assign @seanlaii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanlaii seanlaii

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Karmada Overall Backlog
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update controller-gen version from v0.13.0 to v0.14.0 seanlaii/karmada
3 participants
@RainbowMango @seanlaii @XiShanYongYe-Chang