[Umbrella] Open component imagePullPolicy setting parameters for karmadactl init and karmada operator

[XiShanYongYe-Chang]

What would you like to be added:

Open component imagePullPolicy setting parameters for karmadactl init and karmada operator.

• open component imagePullPolicy setting parameters for karmadactl init. @XiShanYongYe-Chang Add image-pull-policy flag for karmada init cmd #4815
• open component imagePullPolicy setting parameters for karmada operator. @seanlaii Add image-pull-policy field for karmada-operator #4863

Why is this needed:

The helm installation method already provides users with the ability to set the component imagePullPolicy parameters:

karmada/charts/karmada/values.yaml

Lines 28 to 30 in c81649a

	## Specify the imagePullPolicy of karmada images
	## Defaults to 'IfNotPresent', you can set to 'Always' in cases of special needs
	karmadaImagePullPolicy: &karmadaImagePullPolicy IfNotPresent

karmada/charts/karmada/values.yaml

Line 175 in c81649a

pullPolicy: *karmadaImagePullPolicy

In order to ensure the consistency of different installation methods and users can customize the image pull strategy of the Karmada component, we can also provide imagePullPolicy parameter settings for karmadactl init and karmada operator installation methods.

/help

[karmada-bot]

@XiShanYongYe-Chang:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

What would you like to be added:

Open component imagePullPolicy setting parameters for karmadactl init and karmada operator.

• open component imagePullPolicy setting parameters for karmadactl init.
• open component imagePullPolicy setting parameters for karmada operator.

Why is this needed:

The helm installation method already provides users with the ability to set the component imagePullPolicy parameters:

karmada/charts/karmada/values.yaml

Lines 28 to 30 in c81649a

	## Specify the imagePullPolicy of karmada images
	## Defaults to 'IfNotPresent', you can set to 'Always' in cases of special needs
	karmadaImagePullPolicy: &karmadaImagePullPolicy IfNotPresent

karmada/charts/karmada/values.yaml

Line 175 in c81649a

pullPolicy: *karmadaImagePullPolicy

In order to ensure the consistency of different installation methods and users can customize the image pull strategy of the Karmada component, we can also provide imagePullPolicy parameter settings for karmadactl init and karmada operator installation methods.

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[seanlaii]

Hi @XiShanYongYe-Chang , is there anyone working on the second task? I'm interested in working on it if needed.

[XiShanYongYe-Chang]

Hi @XiShanYongYe-Chang , is there anyone working on the second task? I'm interested in working on it if needed.

Thanks~ @seanlaii, I will assign it to you!

[seanlaii]

I would like to clarify the requirement regarding the level of control for the ImagePullPolicy in Karmada Operator. Specifically, should we provide control at the resource level or the component level in the Karmada custom resource?

Currently, the Karmada Operator installs Karmada through a custom resource, Karmada. To address this requirement, I propose adding an ImagePullPolicy field to the CommonSettings field in Karmada custom resource. This approach would enable users to define individual pull policies for each component.
Could you please confirm if this approach aligns with the expected behavior? I appreciate your guidance on ensuring a proper implementation that meets the project's standards and requirements.
Thanks for your time!

[XiShanYongYe-Chang]

This approach would enable users to define individual pull policies for each component.

Thanks a lot. I was expecting something like this.

[XiShanYongYe-Chang]

/assign @XiShanYongYe-Chang @seanlaii

[XiShanYongYe-Chang]

Thanks @seanlaii
All task pr has been merged.
/close

[karmada-bot]

@XiShanYongYe-Chang: Closing this issue.

In response to this:

Thanks @seanlaii
All task pr has been merged.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[seanlaii]

Thank you for your time! Btw, it is worth noting that we might need to upgrade the controller-gen version to 0.14.0 when we upgrade Go version to v1.22 due to this issue. During my local development using Go v1.22, I encountered the same problem. However, after downgrading to Go v1.21.8 or upgrading to controller-gen v0.14.0, everything functioned as expected.

[XiShanYongYe-Chang]

Thanks for the reminder. If it's convenient, you can raise a new issue to track this. We need to do this when we upgrade the go version to 1.22.

[seanlaii]

Sure! I created it here. Please feel free to inform me if I need to add any tags or labels. I am new to creating issues, so your guidance would be greatly appreciated. Thank you!