Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image-pull-policy flag for karmada init cmd #4815

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Apr 9, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

#4789

Which issue(s) this PR fixes:
Part of #4789

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmadactl`: Introduced `--image-pull-policy` flag to the `init` command, which will be used to specify the image pull policy of all components.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 9, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 9, 2024
@XiShanYongYe-Chang
Copy link
Member Author

/cc @RainbowMango

@RainbowMango
Copy link
Member

/assign

pkg/karmadactl/cmdinit/kubernetes/deploy.go Outdated Show resolved Hide resolved
pkg/karmadactl/cmdinit/cmdinit.go Outdated Show resolved Hide resolved
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the add-image-pull-policy-for-karmadactl-init branch from 7ff2442 to 33fa6aa Compare April 10, 2024 02:22
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the add-image-pull-policy-for-karmadactl-init branch from 33fa6aa to bf4510b Compare April 10, 2024 03:00
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
Signed-off-by: changzhen <changzhen5@huawei.com>
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the add-image-pull-policy-for-karmadactl-init branch from bf4510b to 4e82522 Compare April 10, 2024 03:24
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
@XiShanYongYe-Chang
Copy link
Member Author

The UT failed, I pushed it again. @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
@karmada-bot karmada-bot merged commit 210ac04 into karmada-io:master Apr 10, 2024
12 checks passed
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the add-image-pull-policy-for-karmadactl-init branch April 18, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants