Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image-pull-policy field for karmada-operator #4863

Merged

Conversation

seanlaii
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:
#4789

Which issue(s) this PR fixes:
Part of #4789

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Allow the user to specify `imagePullPolicy` in Karmada CR when installing via karmada-operator.

Signed-off-by: wei-chenglai <qazwsx0939059006@gmail.com>
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 24, 2024
@karmada-bot
Copy link
Collaborator

Welcome @seanlaii! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 24, 2024
@XiShanYongYe-Chang
Copy link
Member

@seanlaii Thanks a lot~
/cc @calvin0327 @zhzhuang-zju

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.98%. Comparing base (20bb7a7) to head (d78ea38).
Report is 16 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4863      +/-   ##
==========================================
- Coverage   53.05%   52.98%   -0.08%     
==========================================
  Files         250      250              
  Lines       20371    20421      +50     
==========================================
+ Hits        10808    10820      +12     
- Misses       8845     8882      +37     
- Partials      718      719       +1     
Flag Coverage Δ
unittests 52.98% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju
Copy link
Contributor

@seanlaii nice job~ /lgtm

btw, we can continous to push forward #4401 to add validation of the installation method of the operatoris installed. @XiShanYongYe-Chang

@zhzhuang-zju
Copy link
Contributor

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
@calvin0327
Copy link

/lgtm

thanks for doing this.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ask an approve from @RainbowMango
/assign @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
For the API part.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@karmada-bot karmada-bot merged commit 1e427bb into karmada-io:master Apr 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants