Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #1513: bugfix: aggregate status to binding when work's applied condition status changed #1524

Conversation

mrlihanbo
Copy link

@mrlihanbo mrlihanbo commented Mar 23, 2022

Cherry pick of #1513 on release-1.0.
#1513: bugfix: aggregate status to binding when work's applied condition status changed
For details on the cherry pick process, see the cherry pick requests page.

`karmada-controller-manager`: Fixed RB/CRB controller can't aggregate status in case of work condition update issue.

…tus changed

Signed-off-by: lihanbo <lihanbo2@huawei.com>
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 23, 2022
@mrlihanbo mrlihanbo changed the title Automated cherry pick of #1513: bugfix: aggregate status to binding when work's applied Automated cherry pick of #1513: bugfix: aggregate status to binding when work's applied condition status changed Mar 23, 2022
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2022
@karmada-bot karmada-bot merged commit 722966d into karmada-io:release-1.0 Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants