Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #1604: fix pull mode example error #1609

Conversation

hanweisen
Copy link
Contributor

@hanweisen hanweisen commented Apr 13, 2022

Cherry pick of #1604 on release-1.0.
#1604: fix pull mode example error
For details on the cherry pick process, see the cherry pick requests page.

`karmadactl: fixed the `karmada-system` namespace already existing issue when deploying `karmada-agent` issue.

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 13, 2022
Signed-off-by: hanweisen <hanweisen_yewu@cmss.chinamobile.com>
@hanweisen hanweisen force-pushed the automated-cherry-pick-of-#1604-origin-release-1.0 branch from 1d89dbd to 6776eb3 Compare April 13, 2022 09:35
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Many thanks!

@hanweisen
Copy link
Contributor Author

There is a conflict in docs/installation/installation.md. Use utils.GenExamples("/etc/karmada","kubectl karmada") output replace the conflict part.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2022
@karmada-bot karmada-bot merged commit 11f8edc into karmada-io:release-1.0 Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants