-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pprof for karmada components #2008
Conversation
Please share the test reports and remember to cc the students who are doing the performance thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a good idea. These flags apply to |
9daf78d
to
054e81f
Compare
Maybe the reason why
And finally, @Poor12 By the way, the similar issue happens at |
8657a4b
to
4528cad
Compare
/assign |
e33fab8
to
c9eb604
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me.
Signed-off-by: Poor12 <shentiecheng@huawei.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please describe how to grab the pprof data from Karmada build by |
I just tested it that worked fine. Thanks~ /lgtm |
Signed-off-by: Poor12 shentiecheng@huawei.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Since we need to do some performance tests for karmada components, we found that there are still some components which do not support pprof.
Because each components have different implementing logic, some are based on genericAPIServer, some are base on controller-runtime(controller-runtime now do not support pprof kubernetes-sigs/controller-runtime#1943). In this PR, we unify the config to enable pprof.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Karmada-agent, Karmada-aggregated-apiserver, Karmada-controller-manager, Karmada-descheduler, Karmada-search, Karmada-scheduler, Karmada-scheduler-estimator, Karmada-webhook now support --enable-pprof to enable pprof and --profiling-bind-address to config address for pprof web server.