cleanup pkg import in main function #3012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
the
kind/cleanup
karmada-bot
added
the
size/L
Signed-off-by: Garrybest <garrybest@foxmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3012 +/- ##
==========================================
+ Coverage 38.66% 38.67% +0.01%
==========================================
Files 206 206
Lines 18815 18815
==========================================
+ Hits 7274 7276 +2
+ Misses 11114 11112 -2
Partials 427 427
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
|
Good Job! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Garrybest garrybest@foxmail.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Using
controllerruntime.SetupSignalHandler()instead ofapiserver.SetupSignalContext()to avoid importk8s.io/apiserver/pkg/serverbeforesigs.k8s.io/controller-runtime/pkg/metrics. Refer to #2899.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: