Generate resourcebinding from clusterpropagationpolicy based on the "namespace" exist of the coming resource #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pli
force-pushed
the
generate-resourcebinding-from-clusterpropagationpolicy
branch
from
f13e98d
to
6c93ea3
Compare
|
Thanks!!! I'll review it later, maybe tomorrow. |
…namespace" exist of the comming object Signed-off-by: pengli <justdoit.pli@gmail.com>
vincent-pli
force-pushed
the
generate-resourcebinding-from-clusterpropagationpolicy
branch
from
6c93ea3
to
9dfa74d
Compare
|
Thanks and congrats! @vincent-pli |
XiShanYongYe-Chang
pushed a commit
to XiShanYongYe-Chang/karmada
that referenced
this pull request
Aug 28, 2021
…namespace" exist of the comming object (karmada-io#315) Signed-off-by: pengli <justdoit.pli@gmail.com>
jwcesign
pushed a commit
to jwcesign/karmada
that referenced
this pull request
Jun 8, 2023
add CronJob to build-in AggregateStatus Interpreter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Since
ClusterPropagationPolicyis allowed to point to a namespace scoped resource, so in the scenario aResourceBindingrather thanClusterResourceBindingshould be created.Which issue(s) this PR fixes:
Fixes #300
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE