-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add e2e for schedule with clusterAffinities when replica scheduling type is Divided #3223
[WIP] Add e2e for schedule with clusterAffinities when replica scheduling type is Divided #3223
Conversation
Really? Can it be consistently reproduced? |
This problem can be reproduced by using the resources in the e2e case. |
This e2e I feel very confused, modify the cluster label also to trigger the rescheduler ? |
Yes, when the label of the cluster changes, rescheduling also needs to be triggered, because we can use the label to select the cluster in pp/cpp. |
fd3971d
to
1e4b0d1
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3223 +/- ##
==========================================
- Coverage 56.61% 56.57% -0.05%
==========================================
Files 221 221
Lines 20831 20880 +49
==========================================
+ Hits 11794 11812 +18
- Misses 8413 8444 +31
Partials 624 624
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1e4b0d1
to
4eb0e1e
Compare
f268a0a
to
08d0282
Compare
Signed-off-by: changzhen <changzhen5@huawei.com>
08d0282
to
632bcff
Compare
Since there has been no errors on this case for a long time, close this pr first. |
@XiShanYongYe-Chang: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #3153
Special notes for your reviewer:
When the cluster label changes, resources whose scheduling policy is
Divided
cannot be scheduled again.To solve this problem, we need to update the triggering conditions of the scheduler.
Does this PR introduce a user-facing change?: