Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add e2e for schedule with clusterAffinities when replica scheduling type is Divided #3223

Conversation

XiShanYongYe-Chang
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #3153

Special notes for your reviewer:

When the cluster label changes, resources whose scheduling policy is Divided cannot be scheduled again.

To solve this problem, we need to update the triggering conditions of the scheduler.

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 28, 2023
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 28, 2023
@chaunceyjiang
Copy link
Member

When the cluster label changes, resources whose scheduling policy is Divided cannot be scheduled again.

Really? Can it be consistently reproduced?

@XiShanYongYe-Chang
Copy link
Member Author

XiShanYongYe-Chang commented Feb 28, 2023

Really? Can it be consistently reproduced?

This problem can be reproduced by using the resources in the e2e case.

@chaunceyjiang
Copy link
Member

This e2e I feel very confused, modify the cluster label also to trigger the rescheduler ?

@XiShanYongYe-Chang
Copy link
Member Author

This e2e I feel very confused, modify the cluster label also to trigger the rescheduled ?

Yes, when the label of the cluster changes, rescheduling also needs to be triggered, because we can use the label to select the cluster in pp/cpp.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rainbowmango after the PR has been reviewed.
You can assign the PR to them by writing /assign @rainbowmango in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2023

Codecov Report

Merging #3223 (2abf097) into master (cebb0ca) will decrease coverage by 0.05%.
The diff coverage is 36.45%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3223      +/-   ##
==========================================
- Coverage   56.61%   56.57%   -0.05%     
==========================================
  Files         221      221              
  Lines       20831    20880      +49     
==========================================
+ Hits        11794    11812      +18     
- Misses       8413     8444      +31     
  Partials      624      624              
Flag Coverage Δ
unittests 56.57% <36.45%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/event_handler.go 20.94% <0.00%> (-1.51%) ⬇️
pkg/scheduler/scheduler.go 19.59% <44.30%> (+1.59%) ⬆️

... and 1 file with indirect coverage changes

@XiShanYongYe-Chang XiShanYongYe-Chang marked this pull request as draft June 25, 2023 09:35
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the add-e2e-for-group-schedule branch 3 times, most recently from f268a0a to 08d0282 Compare June 26, 2023 11:02
Signed-off-by: changzhen <changzhen5@huawei.com>
@XiShanYongYe-Chang
Copy link
Member Author

Since there has been no errors on this case for a long time, close this pr first.
/close

@karmada-bot
Copy link
Collaborator

@XiShanYongYe-Chang: Closed this PR.

In response to this:

Since there has been no errors on this case for a long time, close this pr first.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants