-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #3256: feat: add string and math lib for lua #3282
Automated cherry pick of #3256: feat: add string and math lib for lua #3282
Conversation
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## release-1.5 #3282 +/- ##
============================================
Coverage 49.07% 49.07%
============================================
Files 203 203
Lines 18354 18356 +2
============================================
+ Hits 9007 9008 +1
Misses 8858 8858
- Partials 489 490 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @chaunceyjiang, we also need to cherry-pick this path to the release-1.4 branch, can you help do it? |
Cherry pick of #3256 on release-1.5.
#3256: feat: add string and math lib for lua
For details on the cherry pick process, see the cherry pick requests page.