Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UT for deploy.go and statefulset.go #3297

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Add UT for deploy.go and statefulset.go #3297

merged 1 commit into from
Mar 24, 2023

Conversation

realnumber666
Copy link
Contributor

@realnumber666 realnumber666 commented Mar 20, 2023 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Promote UT coverage

Which issue(s) this PR fixes:
#3327

Does this PR introduce a user-facing change?:
NONE

@karmada-bot karmada-bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Mar 20, 2023
@karmada-bot
Copy link
Collaborator

Welcome @realnumber666! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 20, 2023
@XiShanYongYe-Chang
Copy link
Member

Hi @realnumber666, welcome to Karmada, you can sign off refer to https://github.com/karmada-io/karmada/pull/3297/checks?check_run_id=12129764078

@RainbowMango
Copy link
Member

Thanks @realnumber666 for doing this, please sign the DCO during next push, and here is a guide line:https://github.com/karmada-io/karmada/pull/3297/checks?check_run_id=12129764078

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2023 •
edited
Loading

Codecov Report

Merging #3297 (b7c5bc1) into master (40c202b) will increase coverage by 2.13%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3297      +/-   ##
==========================================
+ Coverage   49.15%   51.28%   +2.13%     
==========================================
  Files         208      209       +1     
  Lines       18724    18754      +30     
==========================================
+ Hits         9203     9618     +415     
+ Misses       9021     8637     -384     
+ Partials      500      499       -1
Flag Coverage Δ
unittests 51.28% <ø> (+2.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@realnumber666 realnumber666 changed the title Add UT for deploy.go and statefulset.go [WIP] Add UT for deploy.go and statefulset.go Mar 22, 2023
@karmada-bot karmada-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2023
@realnumber666 realnumber666 changed the title [WIP] Add UT for deploy.go and statefulset.go Add UT for deploy.go and statefulset.go Mar 23, 2023
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2023
@realnumber666 realnumber666 changed the title Add UT for deploy.go and statefulset.go [WIP] Add UT for deploy.go and statefulset.go Mar 23, 2023
@karmada-bot karmada-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2023
@XiShanYongYe-Chang
Copy link
Member

/assign

@realnumber666 realnumber666 force-pushed the add-unit-test branch 2 times, most recently from c7db6c6 to 43a02e4 Compare March 24, 2023 03:17
@realnumber666 realnumber666 changed the title [WIP] Add UT for deploy.go and statefulset.go Add UT for deploy.go and statefulset.go Mar 24, 2023
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2023
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Mar 24, 2023
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thanks~

pkg/karmadactl/cmdinit/kubernetes/deploy_test.go Outdated
ExternalDNS: "example.com",
ExternalIP: "1.2.3.4",
KarmadaAPIServerIP: []net.IP{utils.StringToNetIP("1.2.3.5")},
KarmadaPkiPath: "/tmp/pki",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here can use the tmpPath variable.

@realnumber666
Add UT for deploy.go and statefulset.go
b7c5bc1 
Signed-off-by: rayywu <rayywu@tencent.com>
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Mar 24, 2023
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @lonelyCZ

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2023
@XiShanYongYe-Chang
Copy link
Member

/remove-kind failing-test
/kind cleanup
/cc @RainbowMango

@karmada-bot karmada-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Mar 24, 2023
RainbowMango
RainbowMango approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2023
@karmada-bot karmada-bot merged commit d4c1918 into karmada-io:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@carlory carlory Awaiting requested review from carlory

@prodanlabs prodanlabs Awaiting requested review from prodanlabs

Assignees

@lonelyCZ lonelyCZ

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@realnumber666 @karmada-bot @XiShanYongYe-Chang @RainbowMango @codecov-commenter @lonelyCZ