Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UT for deploy.go #3350

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Add UT for deploy.go #3350

merged 1 commit into from
Apr 4, 2023

Conversation

realnumber666
Copy link
Contributor

@realnumber666 realnumber666 commented Mar 31, 2023 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Promote UT coverage

Which issue(s) this PR fixes:
Part of #3327

Does this PR introduce a user-facing change?:
NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 31, 2023
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 31, 2023
@realnumber666 realnumber666 marked this pull request as draft March 31, 2023 09:12
@karmada-bot karmada-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. labels Mar 31, 2023
@realnumber666 realnumber666 marked this pull request as ready for review March 31, 2023 09:15
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2023
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2023 •
edited
Loading

Codecov Report

Merging #3350 (4335107) into master (5194e17) will increase coverage by 0.18%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3350      +/-   ##
==========================================
+ Coverage   51.50%   51.69%   +0.18%     
==========================================
  Files         210      210              
  Lines       18850    18874      +24     
==========================================
+ Hits         9709     9757      +48     
+ Misses       8642     8597      -45     
- Partials      499      520      +21
Flag Coverage Δ
unittests 51.69% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

RainbowMango
RainbowMango reviewed Apr 3, 2023
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @XiShanYongYe-Chang

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Apr 3, 2023
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
/lgtm

@karmada-bot karmada-bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Apr 3, 2023
@realnumber666 realnumber666 force-pushed the add-unit-test branch 2 times, most recently from 66c7a4a to 8028679 Compare April 3, 2023 09:24
@realnumber666
Add UT for deploy.go and cluster_condition_cache.go
4335107 
Signed-off-by: rayywu <rayywu@tencent.com>
@XiShanYongYe-Chang
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2023
RainbowMango
RainbowMango approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2023
@karmada-bot karmada-bot merged commit 949d589 into karmada-io:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@carlory carlory Awaiting requested review from carlory

@prodanlabs prodanlabs Awaiting requested review from prodanlabs

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@realnumber666 @codecov-commenter @XiShanYongYe-Chang @karmada-bot @RainbowMango