-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support custom metrics for metrics adapter #3638
Conversation
29fa343
to
636c745
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3638 +/- ##
=======================================
Coverage 55.23% 55.24%
=======================================
Files 221 221
Lines 20831 20838 +7
=======================================
+ Hits 11506 11511 +5
- Misses 8715 8717 +2
Partials 610 610
Flags with carried forward coverage won't be shown. Click here to find out more. |
26ebaa3
to
3950e6e
Compare
405434d
to
7461bb3
Compare
7461bb3
to
76c629e
Compare
ef8b8a3
to
6269e9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other lgtm
6269e9a
to
73f04c4
Compare
Nice work! |
cc @Poor12 @RainbowMango for checking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
I'll look at it tomorrow.
LGTM |
73f04c4
to
796d407
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Leave LGTM to @jwcesign for final decision.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @jwcesign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other lgtm
796d407
to
329b01e
Compare
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
329b01e
to
70e5260
Compare
Nice work! |
/lgtm |
/cc @RainbowMango Can you help re-trigger action ? |
Done. This error will be ignored after #3674 . |
What type of PR is this?
/kind feature
What this PR does / why we need it:
support custom metrics for metrics adapter
Which issue(s) this PR fixes:
Part of #3632
Special notes for your reviewer:
Does this PR introduce a user-facing change?: