Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add serviceImport's ips #3832

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zishen
Copy link
Member

@zishen zishen commented Jul 25, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add the ServiceImport ips, come from derived-service.

Which issue(s) this PR fixes:
Fixes #3705

Special notes for your reviewer:
add serviceImport's ips in member cluster.

Does this PR introduce a user-facing change?:
NONE


@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 25, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023

Codecov Report

Merging #3832 (6499b24) into master (ddae25c) will decrease coverage by 0.06%.
Report is 29 commits behind head on master.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3832      +/-   ##
==========================================
- Coverage   54.71%   54.65%   -0.06%     
==========================================
  Files         229      229              
  Lines       22074    22096      +22     
==========================================
- Hits        12077    12076       -1     
- Misses       9351     9372      +21     
- Partials      646      648       +2     
Flag Coverage Δ
unittests 54.65% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/resourceinterpreter/default/native/retain.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@zishen
Copy link
Member Author

zishen commented Jul 25, 2023

@XiShanYongYe-Chang PTAL

@zishen zishen force-pushed the add-serviceimport-ips branch 6 times, most recently from 52a3add to d1dcc70 Compare July 25, 2023 08:10
@XiShanYongYe-Chang
Copy link
Member

/assign

Signed-off-by: Tanggui Bian <softwarebtg@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants