-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix federated-hpa plain metric calc #3922
Conversation
Signed-off-by: zach593 <zach_li@outlook.com>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3922 +/- ##
==========================================
- Coverage 54.72% 54.72% -0.01%
==========================================
Files 229 229
Lines 22065 22065
==========================================
- Hits 12076 12074 -2
- Misses 9343 9345 +2
Partials 646 646
Flags with carried forward coverage won't be shown. Click here to find out more. |
Hi, thank you for synchronizing the PR. Could you please assist in adding the release notes? |
is it fine? @jwcesign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
/lgtm
Thanks!
|
/lgtm |
/cc @RainbowMango |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix plain metric calculation error when usageRatio == 1.0 which I fixed in kubernetes/kubernetes#117845
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: