Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix federated-hpa plain metric calc #3922

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

zach593
Copy link
Contributor

@zach593 zach593 commented Aug 9, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix plain metric calculation error when usageRatio == 1.0 which I fixed in kubernetes/kubernetes#117845

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`kamrada-controller-manager`: Fix federated-HPA plain metric calculation is incorrect when usageRatio == 1.0, keep same with resource replicas.

Signed-off-by: zach593 <zach_li@outlook.com>
@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 9, 2023
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 9, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3922 (fe0febb) into master (8680ff3) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3922      +/-   ##
==========================================
- Coverage   54.72%   54.72%   -0.01%     
==========================================
  Files         229      229              
  Lines       22065    22065              
==========================================
- Hits        12076    12074       -2     
- Misses       9343     9345       +2     
  Partials      646      646              
Flag Coverage Δ
unittests 54.72% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@jwcesign
Copy link
Member

jwcesign commented Aug 9, 2023

Hi, thank you for synchronizing the PR. Could you please assist in adding the release notes?

@zach593
Copy link
Contributor Author

zach593 commented Aug 9, 2023

Fix federated-HPA plain metric calculation is incorrect when usageRatio == 1.0, keep same with resource replicas.

is it fine? @jwcesign

Copy link
Member

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2023
@jwcesign
Copy link
Member

Thanks!

`kamrada-controller-manager`: Fix federated-HPA plain metric calculation is incorrect when usageRatio == 1.0, keep same with resource replicas.

@jwcesign
Copy link
Member

/lgtm

@jwcesign
Copy link
Member

/cc @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@RainbowMango RainbowMango added this to the v1.7 milestone Aug 14, 2023
@karmada-bot karmada-bot merged commit 54e900c into karmada-io:master Aug 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants