Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve overridemanager test #3943

Merged

Conversation

vie-serendipity
Copy link
Contributor

What type of PR is this?

/kind flake
What this PR does / why we need it:
Actually, this doesn't trigger any bugs, but it ought to be of the form `"{{string}}"`. Otherwise there will be no double quotes when converting to a string and cause a marshal error in encoding/json. Just in case developers want to add a unit test on plaintext overrider later, I create this pr.
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

@karmada-bot karmada-bot added the kind/flake Categorizes issue or PR as related to a flaky test. label Aug 15, 2023
@karmada-bot
Copy link
Collaborator

Welcome @vie-serendipity! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 15, 2023
@XiShanYongYe-Chang
Copy link
Member

Hi @vie-serendipity welcome to karmada!
You can sign off refer to https://github.com/karmada-io/karmada/pull/3943/checks?check_run_id=15900231424

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot.
The updated context LGTM

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks @vie-serendipity
You might need to sign the commit as per: #3943 (comment)

/assign @XiShanYongYe-Chang

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Merging #3943 (ec6a83c) into master (25db1e0) will decrease coverage by 0.02%.
Report is 8 commits behind head on master.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3943      +/-   ##
==========================================
- Coverage   54.71%   54.69%   -0.02%     
==========================================
  Files         229      229              
  Lines       22074    22074              
==========================================
- Hits        12077    12074       -3     
- Misses       9351     9354       +3     
  Partials      646      646              
Flag Coverage Δ
unittests 54.69% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Signed-off-by: vie-serendipity <2733147505@qq.com>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@karmada-bot karmada-bot merged commit 999c7ae into karmada-io:master Aug 16, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants