-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update operator default timeout #3944
update operator default timeout #3944
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3944 +/- ##
==========================================
- Coverage 54.70% 54.69% -0.01%
==========================================
Files 229 229
Lines 22074 22074
==========================================
- Hits 12076 12074 -2
- Misses 9352 9354 +2
Partials 646 646
Flags with carried forward coverage won't be shown. Click here to find out more. |
operator/pkg/karmadaresource/webhookconfiguration/webhookconfiguration.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Leave approval to @calvin0327 for the final decision.
I see this PR updates the default timeout for APIserver and ETCD, what about the other components?
During my testing, I found that there was insufficient time to make the changes in these specific areas, while the others were fine. |
It'd be great if we could keep all components with the same timeout. |
/assign |
0c9a6d1
to
7ef4ae3
Compare
Signed-off-by: Vacant2333 <rentian.zhou@daocloud.io>
7ef4ae3
to
a6de637
Compare
Ask an again review for @calvin0327 @RainbowMango |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Leave approval to @carlory for final decisions.
It makes senses to me. /approve A better way is to retry the reconcile func if an error occur. but it's a bit complicated to do now. |
/assign @calvin0327 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carlory, Poor12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
Which issue(s) this PR fixes:
Fixes #3935
Special notes for your reviewer:
Does this PR introduce a user-facing change?: