Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update operator default timeout #3944

Merged

Conversation

Vacant2333
Copy link
Contributor

@Vacant2333 Vacant2333 commented Aug 15, 2023

What type of PR is this?

Which issue(s) this PR fixes:
Fixes #3935

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Merging #3944 (0c9a6d1) into master (6dea121) will decrease coverage by 0.01%.
Report is 16 commits behind head on master.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3944      +/-   ##
==========================================
- Coverage   54.70%   54.69%   -0.01%     
==========================================
  Files         229      229              
  Lines       22074    22074              
==========================================
- Hits        12076    12074       -2     
- Misses       9352     9354       +2     
  Partials      646      646              
Flag Coverage Δ
unittests 54.69% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Leave approval to @calvin0327 for the final decision.

I see this PR updates the default timeout for APIserver and ETCD, what about the other components?

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@Vacant2333
Copy link
Contributor Author

/lgtm

Leave approval to @calvin0327 for the final decision.

I see this PR updates the default timeout for APIserver and ETCD, what about the other components?

During my testing, I found that there was insufficient time to make the changes in these specific areas, while the others were fine.

@RainbowMango
Copy link
Member

During my testing, I found that there was insufficient time to make the changes in these specific areas, while the others were fine

It'd be great if we could keep all components with the same timeout.

@Vacant2333
Copy link
Contributor Author

image

I updated the timeout duration on lines 74, 75, and 77 from 30 seconds to 120 seconds. As for the other components, they are all covered on lines 80 and 81, and their default timeout is already set to 120 seconds, so there's no need for updates there.
Alright, I'll make the modifications accordingly.

@karmada-bot karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 15, 2023
@calvin0327
Copy link

/assign

@Vacant2333 Vacant2333 force-pushed the update_operator_default_timeout branch from 0c9a6d1 to 7ef4ae3 Compare August 17, 2023 02:23
Signed-off-by: Vacant2333 <rentian.zhou@daocloud.io>
@Vacant2333 Vacant2333 force-pushed the update_operator_default_timeout branch from 7ef4ae3 to a6de637 Compare August 17, 2023 06:22
@XiShanYongYe-Chang
Copy link
Member

Ask an again review for @calvin0327 @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Leave approval to @carlory for final decisions.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2023
@carlory
Copy link
Member

carlory commented Aug 18, 2023

It makes senses to me.

/approve

A better way is to retry the reconcile func if an error occur. but it's a bit complicated to do now.

@carlory
Copy link
Member

carlory commented Aug 18, 2023

/assign @calvin0327

@Poor12
Copy link
Member

Poor12 commented Aug 18, 2023

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, Poor12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2023
@karmada-bot karmada-bot merged commit 276d6a8 into karmada-io:master Aug 18, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

operator init operations may need bigger timeout
8 participants