ResourceSummary add check index for -1

[liangyuanpeng]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Check for invaild index to avoid the panic.

Related:

• karmada-controller-manager: panic: runtime error: index out of range #3854

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[RainbowMango]

I guess @halfrost is still trying to figure out the root cause at #3854.
Let's wait for a while.

[liangyuanpeng]

I guess @halfrost is still trying to figure out the root cause at #3854.

Absolutely, So this PR would not to close the issue. just add the defensive code to avoid the panic.

[halfrost]

I guess @halfrost is still trying to figure out the root cause at #3854. Let's wait for a while.

Yes, indeed, I tested my code in the testing environment myself. I haven't been able to reproduce the #3854 issue mentioned. I'm also waiting for them to provide more detailed logs. Because the right interval of the last interval is positive infinity, it's certain that corresponding modeling can be found. Returning -1 is a requirement of goformat tool: each branch needs to return a value.

I agree with this PR, adding this defensive code will enhance the stability of Karmada. As for issue #3854 , once that guys provides more detailed logs to replicate the panic, I can promptly fix it.

[RainbowMango]

/lgtm
/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment