-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add karmada resource clusterrole for helm install #3957
Feat: Add karmada resource clusterrole for helm install #3957
Conversation
Signed-off-by: Vacant2333 <vacant2333@gmail.com>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3957 +/- ##
==========================================
- Coverage 54.70% 54.69% -0.02%
==========================================
Files 229 229
Lines 22074 22086 +12
==========================================
+ Hits 12076 12080 +4
- Misses 9352 9358 +6
- Partials 646 648 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
/assign @pidb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liangyuanpeng, RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
add admin clusterrole for karmada resources when helm install
Which issue(s) this PR fixes:
Part of #3916
Special notes for your reviewer:
Test:
install by helm, and create the clusterroles
Does this PR introduce a user-facing change?: