-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Response to priority change of ClusterPropagationPolicy #3990
Conversation
and enqueue ClusterPropagationPolicy that could repreempte. Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
add test case, and verified ok
apiVersion: policy.karmada.io/v1alpha1
kind: ClusterPropagationPolicy
metadata:
name: foo
spec:
priority: 5
preemption: Always
resourceSelectors:
- apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
name: test-role
placement:
clusterAffinity:
clusterNames:
- member1
---
apiVersion: policy.karmada.io/v1alpha1
kind: ClusterPropagationPolicy
metadata:
name: bar
spec:
priority: 4
preemption: Always
resourceSelectors:
- apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
name: test-role
placement:
clusterAffinity:
clusterNames:
- member2
kubectl create clusterrole test-role --verb=get,list,watch --resource=pods
Result:
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
creationTimestamp: "2023-08-24T08:57:51Z"
labels:
clusterpropagationpolicy.karmada.io/name: bar
name: test-role
|
Please update test report as per your testing. When a PropagationPolicy propagates a Line 38 in 5e8a765
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR provides a temporary solution for corner case:
Which issue(s) this PR fixes:
Fixes #
Part of #3787
Special notes for your reviewer:
See #3684 (comment) for the background discussion.
In addition, this PR focuses on dealing with
ClusterPropagationPolicy
, the PR ofPropagationPolicy
see #3965.Test steps:
meanwhile, I can see the relevant logs:
more test see:
#3990 (comment)
Does this PR introduce a user-facing change?: