feature: Add the UID of the owner resource in labels and include the details in annotations.

[jwcesign]

What type of PR is this?
/kind feature

What this PR does / why we need it:
As mentioned in #4000

Which issue(s) this PR fixes:
Part of #4000

Special notes for your reviewer:
none

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: Include the UID of the owner resource in labels and provide the details in annotations. If users are using related labels as label selectors, they should switch to using the UID as the label selector.

[jwcesign]

/cc @RainbowMango @wu0407 @whitewindmills

[karmada-bot]

@jwcesign: GitHub didn't allow me to request PR reviews from the following users: wu0407.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @RainbowMango @wu0407 @whitewindmills

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jwcesign]

Note: In version v1.8.0, we will remove the old labels, resolving the issue of excessively long label values.

Testing report: https://docs.google.com/document/d/1FgHm5gdgSB9cuSj526i6P-1g9lUwIaaeXAt-bUjM834/edit?usp=sharing

[codecov-commenter]

Codecov Report

Merging #4007 (2c48bd7) into master (fb4c16d) will increase coverage by 0.11%.
Report is 8 commits behind head on master.
The diff coverage is 14.51%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #4007      +/-   ##
==========================================
+ Coverage   54.48%   54.59%   +0.11%     
==========================================
  Files         232      232              
  Lines       22685    22894     +209     
==========================================
+ Hits        12359    12500     +141     
- Misses       9649     9715      +66     
- Partials      677      679       +2     

Flag	Coverage Δ
unittests	54.59% <14.51%> (+0.11%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
pkg/detector/detector.go	0.00% <0.00%> (ø)
pkg/detector/preemption.go	0.00% <0.00%> (ø)
pkg/util/annotation.go	84.12% <0.00%> (-12.24%)	⬇️
pkg/controllers/binding/common.go	47.72% <88.88%> (+2.16%)	⬆️
pkg/controllers/execution/execution_controller.go	59.35% <100.00%> (ø)

... and 7 files with indirect coverage changes

[RainbowMango]

/assign

[RainbowMango]

This test is failing:

--- FAIL: TestExecutionController_syncWork (0.59s)
    --- PASS: TestExecutionController_syncWork/failed_to_GetObjectFromCache,_wrong_InformerManager_in_ExecutionController (0.03s)
    --- PASS: TestExecutionController_syncWork/obj_not_found_in_informer,_wrong_dynamicClientSet_without_pod (0.13s)
    --- PASS: TestExecutionController_syncWork/workNamespace_is_zero (0.13s)
    --- PASS: TestExecutionController_syncWork/failed_to_exec_Client.Get,_set_wrong_cluster_name_in_work (0.13s)
    --- PASS: TestExecutionController_syncWork/cluster_is_not_ready (0.04s)
    --- FAIL: TestExecutionController_syncWork/normal_case (0.14s)
FAIL
	github.com/karmada-io/karmada/pkg/controllers/execution	coverage: 67.7% of statements
FAIL	github.com/karmada-io/karmada/pkg/controllers/execution	1.168s
?   	github.com/karmada-io/karmada/pkg/controllers/federatedhpa	[no test files]
?   	github.com/karmada-io/karmada/pkg/controllers/federatedhpa/config	[no test files]
?   	github.com/karmada-io/karmada/pkg/controllers/federatedhpa/monitor	[no test files]

[whitewindmills]

/lgtm

[RainbowMango]

/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wu0407]

This PR does not fix the create resource binding failed by DependenciesDistributor, it only fixes the failed to create resource for the member cluster.

[RainbowMango]

I think this PR doesn't fix anything, it just introduced a uid label(like propagationpolicy.karmada.io/uid) and annotations, like propagationpolicy.karmada.io/namespace.

This PR does not fix the create resource binding failed by DependenciesDistributor

Do you mean this PR missed the changes that should made for DependenciesDistributor?

[wu0407]

I misunderstood this PR and indeed missed a DependenciesDistributor

[RainbowMango]

Can you help to show me the code?

[wu0407]

karmada/pkg/dependenciesdistributor/dependencies_distributor.go

Lines 623 to 654 in 641681d

	func buildAttachedBinding(binding *workv1alpha2.ResourceBinding, object *unstructured.Unstructured) *workv1alpha2.ResourceBinding {
	dependedLabels := generateBindingDependedLabels(binding.Namespace, binding.Name)
	var result []workv1alpha2.BindingSnapshot
	result = append(result, workv1alpha2.BindingSnapshot{
	Namespace: binding.Namespace,
	Name: binding.Name,
	Clusters: binding.Spec.Clusters,
	})
	return &workv1alpha2.ResourceBinding{
	ObjectMeta: metav1.ObjectMeta{
	Name: names.GenerateBindingName(object.GetKind(), object.GetName()),
	Namespace: binding.GetNamespace(),
	OwnerReferences: []metav1.OwnerReference{
	*metav1.NewControllerRef(object, object.GroupVersionKind()),
	},
	Labels: dependedLabels,
	Finalizers: []string{util.BindingControllerFinalizer},
	},
	Spec: workv1alpha2.ResourceBindingSpec{
	Resource: workv1alpha2.ObjectReference{
	APIVersion: object.GetAPIVersion(),
	Kind: object.GetKind(),
	Namespace: object.GetNamespace(),
	Name: object.GetName(),
	ResourceVersion: object.GetResourceVersion(),
	},
	RequiredBy: result,
	},
	}
	}

[jwcesign]

I checked the code, there is no label about: propagationpolicy.karmada.io/xxx for dependency rb.

So it's two problems.

But indeed, there is a problem with too long label value(namesapce-63-char + rb-63-char):

karmada/pkg/dependenciesdistributor/dependencies_distributor.go

Line 606 in 9003c83

labelValue := fmt.Sprintf(bindingNamespace + "_" + bindingName)

So in the next release, we will cut the label value as a hash, and the namespace and name information will be moved to annotation.

cc @wu0407
How do u think?

[wu0407]

is the next release 1.7?

[jwcesign]

is the next release 1.7?

I think release-1.8,