-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Add the UID of the owner resource in labels and include the details in annotations. #4007
Conversation
@jwcesign: GitHub didn't allow me to request PR reviews from the following users: wu0407. Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Note: In version v1.8.0, we will remove the old labels, resolving the issue of excessively long label values. Testing report: https://docs.google.com/document/d/1FgHm5gdgSB9cuSj526i6P-1g9lUwIaaeXAt-bUjM834/edit?usp=sharing |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #4007 +/- ##
==========================================
+ Coverage 54.48% 54.59% +0.11%
==========================================
Files 232 232
Lines 22685 22894 +209
==========================================
+ Hits 12359 12500 +141
- Misses 9649 9715 +66
- Partials 677 679 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
48c989e
to
bddd5a8
Compare
bddd5a8
to
12230ce
Compare
This test is failing:
|
Signed-off-by: jwcesign <jwcesign@gmail.com>
12230ce
to
2c48bd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR does not fix the create resource binding failed by |
I think this PR doesn't fix anything, it just introduced a uid label(like
Do you mean this PR missed the changes that should made for |
I misunderstood this PR and indeed missed a DependenciesDistributor |
Can you help to show me the code? |
karmada/pkg/dependenciesdistributor/dependencies_distributor.go Lines 623 to 654 in 641681d
|
I checked the code, there is no label about: So it's two problems. But indeed, there is a problem with too long label value(namesapce-63-char + rb-63-char):
So in the next release, we will cut the label value as a hash, and the namespace and name information will be moved to annotation. cc @wu0407 |
is the next release 1.7? |
I think release-1.8, |
What type of PR is this?
/kind feature
What this PR does / why we need it:
As mentioned in #4000
Which issue(s) this PR fixes:
Part of #4000
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?: