Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator e2e init #4148

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liangyuanpeng
Copy link
Contributor

What type of PR is this?
/kind cleanup
What this PR does / why we need it:

Init operator e2e test.

Which issue(s) this PR fixes:

Related:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 18, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign garrybest after the PR has been reviewed.
You can assign the PR to them by writing /assign @garrybest in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liangyuanpeng liangyuanpeng marked this pull request as draft October 18, 2023 09:20
@karmada-bot karmada-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 18, 2023
@liangyuanpeng
Copy link
Contributor Author

liangyuanpeng commented Oct 18, 2023

I was hoping to get some advice to confirm that i have on the right side:

  • Create a separate github workflow to run operator e2e test,
  • Keep the e2e test at test/e2e_operator and not test/e2e, Test decoupling from karmada and facilitate subsequent independent operator projects

/cc @RainbowMango @calvin0327

@RainbowMango
Copy link
Member

Create a separate github workflow to run operator e2e test,

Just a question, why do you think we need another workflow for karmada-operator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants