-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
karmadactl supports top node #4224
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4224 +/- ##
==========================================
- Coverage 29.67% 29.52% -0.15%
==========================================
Files 632 633 +1
Lines 43936 44127 +191
==========================================
- Hits 13037 13029 -8
- Misses 29954 30152 +198
- Partials 945 946 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d083855
to
c5988fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me.
@chaunceyjiang Can you help to take a look? As it's similar to top pods
.
/assign |
5eda1d9
to
eebd5f6
Compare
0ddb6de
to
b3f7554
Compare
kindly ping @chaunceyjiang @RainbowMango |
Signed-off-by: zhzhuang-zju <m17799853869@163.com>
b3f7554
to
3af667c
Compare
@hulizhe @RainbowMango The previous proposal envisioned that the $ kubectl --kubeconfig $HOME/.kube/karmada.config --context karmada-apiserver top pod
NAME CPU(cores) MEMORY(bytes)
nginx 0m 3Mi
nginx 0m 2Mi
nginx 0m 3Mi
$ kubectl --kubeconfig $HOME/.kube/karmada.config --context karmada-apiserver top node
NAME CPU(cores) CPU% MEMORY(bytes) MEMORY%
member1-control-plane 85m 725Mi
member2-control-plane 87m 715Mi
member3-control-plane 94m 786Mi So, it would be better to limit the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
It looks great!
# _output/bin/linux/amd64/karmadactl top nodes
NAME CLUSTER CPU(cores) CPU% MEMORY(bytes) MEMORY%
member1-control-plane member1 292m 7% 779Mi 4%
member2-control-plane member2 98m 2% 772Mi 4%
member3-control-plane member3 104m 2% 869Mi 5%
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
karmadactl supports top node
Which issue(s) this PR fixes:
Parts of #4217
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?: