Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FleetAPIServer Proposal #4317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Nov 24, 2023

What type of PR is this?

/kind design
/kind documentation

What this PR does / why we need it:

Add FleetAPIServer, providing a unified view of resources across multiple clusters.

Which issue(s) this PR fixes:
Part of #4319

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added kind/design Categorizes issue or PR as related to design. kind/documentation Categorizes issue or PR as related to documentation. labels Nov 24, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rainbowmango after the PR has been reviewed.
You can assign the PR to them by writing /assign @rainbowmango in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 24, 2023
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the add-fleetapiserver-proposal branch 2 times, most recently from 6ed3384 to 6aac179 Compare November 24, 2023 08:14
@XiShanYongYe-Chang
Copy link
Member Author

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cac0bdf) 52.00% compared to head (dd9b056) 52.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4317   +/-   ##
=======================================
  Coverage   52.00%   52.00%           
=======================================
  Files         242      242           
  Lines       23984    23984           
=======================================
  Hits        12474    12474           
  Misses      10830    10830           
  Partials      680      680           
Flag Coverage Δ
unittests 52.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangyuanpeng
Copy link
Contributor

cc

Signed-off-by: changzhen <changzhen5@huawei.com>

### Implementation plan

To be supplemented.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the code location, it's better to:

  1. fork kubernetes/kubernetes to karmada-io/kubernetes, and add only contain the necessary inline changes to make the kube-apiserver kube-apiserver programmable for implementing the fleet-apiserver.
  2. The rest of the fleet-apiserver code should be stored in a separate place, better a staging repo in karmada-io/karmada, but a stand-alone repo can be an option as well.


The architecture diagram of FleetAPIServer is given below.

![fleetapiserver architecture](./statics/fleetapiserver-architecture.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify whether it's required that fleet-apiserver and karmada-apiserver use the same etcd, as it would result in different deployment constraints.
And since the fleet-apiserver and karmada-apiserver are using the same etcd, it's better to differentiate between write and read-only api calls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design. kind/documentation Categorizes issue or PR as related to documentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants