-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FleetAPIServer Proposal #4317
base: master
Are you sure you want to change the base?
Add FleetAPIServer Proposal #4317
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6ed3384
to
6aac179
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4317 +/- ##
=======================================
Coverage 52.00% 52.00%
=======================================
Files 242 242
Lines 23984 23984
=======================================
Hits 12474 12474
Misses 10830 10830
Partials 680 680
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cc |
Signed-off-by: changzhen <changzhen5@huawei.com>
6aac179
to
dd9b056
Compare
|
||
### Implementation plan | ||
|
||
To be supplemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the code location, it's better to:
- fork kubernetes/kubernetes to karmada-io/kubernetes, and add only contain the necessary inline changes to make the kube-apiserver kube-apiserver programmable for implementing the fleet-apiserver.
- The rest of the fleet-apiserver code should be stored in a separate place, better a staging repo in karmada-io/karmada, but a stand-alone repo can be an option as well.
|
||
The architecture diagram of FleetAPIServer is given below. | ||
|
||
![fleetapiserver architecture](./statics/fleetapiserver-architecture.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clarify whether it's required that fleet-apiserver and karmada-apiserver use the same etcd, as it would result in different deployment constraints.
And since the fleet-apiserver and karmada-apiserver are using the same etcd, it's better to differentiate between write and read-only api calls
What type of PR is this?
/kind design
/kind documentation
What this PR does / why we need it:
Add FleetAPIServer, providing a unified view of resources across multiple clusters.
Which issue(s) this PR fixes:
Part of #4319
Special notes for your reviewer:
Does this PR introduce a user-facing change?: