make estimator config in helm values as a list #4358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/M
chaosi-zju
force-pushed
the
feat-estimitor
branch
from
f9e7a74 to
d8ce122
Compare
karmada-bot
added
size/L
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4358 +/- ##
==========================================
- Coverage 51.90% 51.89% -0.01%
==========================================
Files 243 243
Lines 24146 24146
==========================================
- Hits 12532 12531 -1
Misses 10931 10931
- Partials 683 684 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chaosi-zju
force-pushed
the
feat-estimitor
branch
2 times, most recently
from
c3c0caa to
d4ad908
Compare
chaosi-zju
force-pushed
the
feat-estimitor
branch
from
d4ad908 to
3da3df7
Compare
|
CC @RainbowMango ready to merge |
RainbowMango
reviewed
Dec 9, 2023
chaosi-zju
force-pushed
the
feat-estimitor
branch
from
3da3df7 to
712de0c
Compare
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
chaosi-zju
force-pushed
the
feat-estimitor
branch
from
712de0c to
69a3ced
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
make estimator config in helm values as a list
#4050 (comment)
Which issue(s) this PR fixes:
Fixes #4368
Special notes for your reviewer:
Does this PR introduce a user-facing change?: