Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete the e2e test case scenarios for clusterpp #4575

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

zhzhuang-zju
Copy link
Contributor

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
complete the e2e test case scenarios for clusterpp.
Additional scenes include:

  • Deployment propagation testing
    create a ClusterPropagationPolicy for deployment and then update deployment replicas
  • [ImplicitPriority] propagation testing
    priority: MatchName>MatchLabel>MatchAll
  • delete the old ClusterPropagationPolicy to unbind and create a new one(namespace scope and cluster scope)

Which issue(s) this PR fixes:
parts of # 4544

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jan 23, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 23, 2024
@zhzhuang-zju
Copy link
Contributor Author

cc @Vacant2333 @XiShanYongYe-Chang

@XiShanYongYe-Chang
Copy link
Member

Hi @Vacant2333, can you help take a review?
/assign @Vacant2333

@Vacant2333
Copy link
Contributor

@XiShanYongYe-Chang looks good to me
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
@XiShanYongYe-Chang
Copy link
Member

Hi @zhzhuang-zju, can you help rebase the master branch and push again?

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.26%. Comparing base (d3adcf6) to head (d43a119).
Report is 41 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4575      +/-   ##
==========================================
+ Coverage   28.23%   28.26%   +0.02%     
==========================================
  Files         632      632              
  Lines       43712    43732      +20     
==========================================
+ Hits        12344    12359      +15     
- Misses      30465    30472       +7     
+ Partials      903      901       -2     
Flag Coverage Δ
unittests 28.26% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju
Copy link
Contributor Author

/retest
Oddly, the e2e test has been failing episodically quite frequently lately.

@zhzhuang-zju
Copy link
Contributor Author

cc @XiShanYongYe-Chang @Vacant2333

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

test/e2e/clusterpropagationpolicy_test.go Outdated Show resolved Hide resolved
test/e2e/clusterpropagationpolicy_test.go Outdated Show resolved Hide resolved
test/e2e/clusterpropagationpolicy_test.go Outdated Show resolved Hide resolved
test/e2e/clusterpropagationpolicy_test.go Outdated Show resolved Hide resolved
test/e2e/framework/clusterpropagationpolicy.go Outdated Show resolved Hide resolved
Signed-off-by: zhzhuang-zju <m17799853869@163.com>
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot~
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2024
@karmada-bot karmada-bot merged commit 39e8587 into karmada-io:master Jul 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants