-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
complete the e2e test case scenarios for clusterpp #4575
Conversation
Hi @Vacant2333, can you help take a review? |
@XiShanYongYe-Chang looks good to me |
Hi @zhzhuang-zju, can you help rebase the master branch and push again? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4575 +/- ##
==========================================
+ Coverage 28.23% 28.26% +0.02%
==========================================
Files 632 632
Lines 43712 43732 +20
==========================================
+ Hits 12344 12359 +15
- Misses 30465 30472 +7
+ Partials 903 901 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a1653b9
to
94e5c49
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot
Signed-off-by: zhzhuang-zju <m17799853869@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot~
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
complete the e2e test case scenarios for clusterpp.
Additional scenes include:
create a ClusterPropagationPolicy for deployment and then update deployment replicas
priority: MatchName>MatchLabel>MatchAll
Which issue(s) this PR fixes:
parts of # 4544
Special notes for your reviewer:
Does this PR introduce a user-facing change?: