-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove work label on the member cluster resource #4765
Remove work label on the member cluster resource #4765
Conversation
07628df
to
82b5803
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4765 +/- ##
==========================================
- Coverage 51.79% 51.78% -0.02%
==========================================
Files 250 250
Lines 24991 24989 -2
==========================================
- Hits 12945 12940 -5
- Misses 11337 11339 +2
- Partials 709 710 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: changzhen <changzhen5@huawei.com>
82b5803
to
0e60af8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you @XiShanYongYe-Chang 🏆 |
Looking forward to your feedback :) |
Confirm the change fixes our issue on sync failure for resource name > 63 chars. Thanks, team! ❤️ |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Karmada will generate the work namespace/name labels on the resources propagated to member clusters:
When the created resource name is longer than 63 characters, those labels will cause the resource to fail to be created successfully in the member cluster.
So we need to remove those labels from resources propagated to member clusters.
Which issue(s) this PR fixes:
Fixes #4683
Special notes for your reviewer:
Does this PR introduce a user-facing change?: