Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove work label on the member cluster resource #4765

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Mar 28, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Karmada will generate the work namespace/name labels on the resources propagated to member clusters:

  • work.karmada.io/namespace
  • work.karmada.io/name

When the created resource name is longer than 63 characters, those labels will cause the resource to fail to be created successfully in the member cluster.

So we need to remove those labels from resources propagated to member clusters.

Which issue(s) this PR fixes:
Fixes #4683

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-controller-manager: remove the work namespace/name labels from resources propagated to member clusters

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 28, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 28, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the remove-work-label-on-the-member-cluster-resource branch 3 times, most recently from 07628df to 82b5803 Compare March 28, 2024 04:16
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 51.78%. Comparing base (ff7322a) to head (0e60af8).

Files Patch % Lines
pkg/controllers/binding/common.go 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4765      +/-   ##
==========================================
- Coverage   51.79%   51.78%   -0.02%     
==========================================
  Files         250      250              
  Lines       24991    24989       -2     
==========================================
- Hits        12945    12940       -5     
- Misses      11337    11339       +2     
- Partials      709      710       +1     
Flag Coverage Δ
unittests 51.78% <85.71%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: changzhen <changzhen5@huawei.com>
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the remove-work-label-on-the-member-cluster-resource branch from 82b5803 to 0e60af8 Compare March 28, 2024 04:56
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
@karmada-bot karmada-bot merged commit 7d4bd4b into karmada-io:master Mar 28, 2024
12 checks passed
@a7i
Copy link
Contributor

a7i commented Mar 28, 2024

Thank you @XiShanYongYe-Chang 🏆
We'll give this a try over the next day or two

@XiShanYongYe-Chang
Copy link
Member Author

We'll give this a try over the next day or two

Looking forward to your feedback :)

@yizhang-zen
Copy link
Contributor

Confirm the change fixes our issue on sync failure for resource name > 63 chars. Thanks, team! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to create or update resource longer than 63 chars
6 participants