-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected poll timeout example #4783
Conversation
Welcome @Jay179-sudo! It looks like this is your first PR to karmada-io/karmada 🎉 |
Signed-off-by: Jay179-sudo <jayprasad2002@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks for your contribution
/assign @XiShanYongYe-Chang |
@Jay179-sudo Thanks~ |
Done. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango, Vacant2333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4783 +/- ##
=======================================
Coverage 51.76% 51.76%
=======================================
Files 250 250
Lines 24980 24980
=======================================
Hits 12930 12930
Misses 11340 11340
Partials 710 710
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What type of PR is this?
This PR corrects a small documentation error.
/kind documentation
What this PR does / why we need it:
Fixes small documentation errors.
Which issue(s) this PR fixes:
Fixes #4775
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?: