Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected poll timeout example #4783

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

Jay179-sudo
Copy link
Contributor

What type of PR is this?

This PR corrects a small documentation error.
/kind documentation

What this PR does / why we need it:

Fixes small documentation errors.

Which issue(s) this PR fixes:
Fixes #4775

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 30, 2024
@karmada-bot
Copy link
Collaborator

Welcome @Jay179-sudo! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 30, 2024
Signed-off-by: Jay179-sudo <jayprasad2002@gmail.com>
Copy link
Contributor

@Vacant2333 Vacant2333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks for your contribution

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2024
@Jay179-sudo
Copy link
Contributor Author

/assign @XiShanYongYe-Chang
Looking forward to more!

@XiShanYongYe-Chang
Copy link
Member

@Jay179-sudo Thanks~
Ask @RainbowMango to help run the CI.
/cc @RainbowMango

@RainbowMango
Copy link
Member

Ask @RainbowMango to help run the CI.

Done.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango, Vacant2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.76%. Comparing base (6534ffb) to head (deaf341).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4783   +/-   ##
=======================================
  Coverage   51.76%   51.76%           
=======================================
  Files         250      250           
  Lines       24980    24980           
=======================================
  Hits        12930    12930           
  Misses      11340    11340           
  Partials      710      710           
Flag Coverage Δ
unittests 51.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karmada-bot karmada-bot merged commit d9377e7 into karmada-io:master Apr 1, 2024
12 checks passed
@Jay179-sudo Jay179-sudo deleted the test-demo branch April 1, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the worng example comment in the e2e suite
6 participants